feat: add boot-counting support to lanzaboote #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-vdp
force-pushed
the
rvdp/boot_counting
branch
2 times, most recently
from
b637024 to
c582aa8
Compare
Member
|
Interesting! It will take me some time to get to this. If there is a way to split this into smaller PRs that would help speed things up! |
Contributor
Author
|
Yeah I can split it, the reason that I didn't is that the earlier commits don't add much value by themselves besides preparing for the boot counting implementation, so I'm not sure that it would make much sense to merge those separately. But if it would make reviewing easier for you, then I can definitely create individual PRs, more or less corresponding to the commits in this one. |
r-vdp
force-pushed
the
rvdp/boot_counting
branch
2 times, most recently
from
1d3dad7 to
b8d1322
Compare
r-vdp
changed the title
Contributor
Author
r-vdp
force-pushed
the
rvdp/boot_counting
branch
4 times, most recently
from
fd1e46a to
79aa29e
Compare
r-vdp
force-pushed
the
rvdp/boot_counting
branch
from
79aa29e to
9be9e1d
Compare
r-vdp
force-pushed
the
rvdp/boot_counting
branch
4 times, most recently
from
a6387e7 to
43efce1
Compare
r-vdp
force-pushed
the
rvdp/boot_counting
branch
from
43efce1 to
d288378
Compare
See https://systemd.io/AUTOMATIC_BOOT_ASSESSMENT/ Boot counting is controlled with a single option, `boot.lanzaboote.bootCounting.initialTries`, if this option is set to a non-zero value, new boot entries will be created with a counter added, set to the value specified in that option. If the option is set to zero, which is also the default, then no boot-counting counters will be added. Already existing entries will not be modified, so boot counting only applies to new boot entries.
r-vdp
force-pushed
the
rvdp/boot_counting
branch
from
d288378 to
1d77ad4
Compare
Contributor
Author
|
With #479 merged (thanks @nikstur!), this is now ready for review, @blitz, @RaitoBezarius, @nikstur (for some reason I don't have permission to actually request reviews on this repo, hence the pings). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://systemd.io/AUTOMATIC_BOOT_ASSESSMENT/
Boot counting is controlled with a single option,
boot.lanzaboote.bootCounting.initialTries, if this option is set to a non-zero value, new boot entries will be created with a counter added, set to the value specified in that option. If the option is set to zero, which is also the default, then no boot-counting counters will be added.Already existing entries will not be modified, so boot counting only applies to new boot entries.
CC: @RaitoBezarius