WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@aabccd021
Copy link
Member

This flag allows users to run nixos-anywhere with extra settings for SSH store, by appending it to ssh store url.

If a user has fast connection between client and target, but slow internet connection on target, the user can use --no-substitute-on-destination to copy closures from client instead of downloading it from internet.

The copy speed (nix-copy to ssh store) can be greatly improved by enabling compression via --ssh-store-settings "compress=true".

Existing url parameters (especially the special characters) need to be encoded to avoid unexpected results. Otherwise we will get something like root evaluates to /mnt?compression=true.

@aabccd021
Copy link
Member Author

The code intentionally have ? and & at the end of the URL even without store settings passed, which is still a valid URL.

This is done to avoid complexity and make the PR diff as small as possible.

Please let me know if we want to not include these characters when ssh store settings are not used.

@phaer
Copy link
Member

phaer commented Oct 19, 2024

@aabccd021 Sorry for the delayed response. Idea sounds good to me - could you rebase?

@aabccd021 aabccd021 closed this Oct 19, 2024
@aabccd021 aabccd021 reopened this Oct 19, 2024
@aabccd021
Copy link
Member Author

@phaer Just rebased. Could you check?

@phaer phaer added this pull request to the merge queue Feb 24, 2025
Merged via the queue into nix-community:main with commit 40f5d37 Feb 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants