Revert breaking changes

Author: Corentin Lefebvre

lib/js/DockManager.d.ts

@@ -5,7 +5,6 @@ import { DockManagerContext } from "./DockManagerContext.js";
 import { DockModel } from "./DockModel.js";
 import { DockNode } from "./DockNode.js";
 import { DockWheel } from "./DockWheel.js";
-import { ResizeDirection } from "./enums/ResizeDirection.js";
 import { EventHandler } from "./EventHandler.js";
 import { IDockContainer } from "./interfaces/IDockContainer.js";
 import { ILayoutEventListener } from "./interfaces/ILayoutEventListener.js";
@@ -91,7 +90,7 @@ export declare class DockManager {
     dockDown(referenceNode: DockNode, container: PanelContainer, ratio: number): DockNode;
     /** Dock the [container] as a tab inside the [referenceNode] node */
     dockFill(referenceNode: DockNode, container: PanelContainer): DockNode;
-    floatDialog(container: PanelContainer, x: number, y: number, grayoutParent?: PanelContainer, resizeDirection?: ResizeDirection): Dialog;
+    floatDialog(container: PanelContainer, x: number, y: number, grayoutParent?: PanelContainer, disableResize?: boolean): Dialog;
     private _requestDockDialog;
     private _checkShowBackgroundContext;
     private _requestDockContainer;
@@ -109,7 +108,7 @@ export declare class DockManager {
      * Opens a Element in a Dialog
      * It is assumed that only leaf nodes (panels) can be undocked
      */
-    openInDialog(container: PanelContainer, event: any, dragOffset: Point, resizeDirection?: ResizeDirection): Dialog;
+    openInDialog(container: PanelContainer, event: any, dragOffset: Point, disableResize?: boolean): Dialog;
     /** Undocks a panel and converts it into a floating dialog window
      * It is assumed that only leaf nodes (panels) can be undocked
      */

lib/js/DockManager.js

@@ -1,7 +1,6 @@
 import { DockManager } from "../../../lib/js/DockManager.js";
 import { PanelContainer } from "../../../lib/js/PanelContainer.js";
 import { PanelType } from "../../../lib/js/enums/PanelType.js";
-import { ResizeDirection } from "../../../lib/js/enums/ResizeDirection.js";
 
 let dockManager,
     storeKey = 'lastState';
@@ -143,7 +142,7 @@ window.onload = () => {
         dockManager.dockRight(documentNode, toolbox, 0.20);
         dockManager.dockFill(documentNode, editor1);
         dockManager.dockFill(documentNode, editor2);
-        dockManager.floatDialog(infovisContainer, 50, 50, null, ResizeDirection.None);
+        dockManager.floatDialog(infovisContainer, 50, 50, null, true);
     }
 
     document.getElementById("dlg").onclick = () => {

lib/js/DockManager.js.map

@@ -18,7 +18,7 @@ export class Dialog implements IContextMenuProvider {
     eventListener: DockManager;
     position: Point;
     resizable: ResizableContainer;
-    resizeDirection: ResizeDirection;
+    disableResize: boolean;
     mouseDownHandler: any;
     onKeyPressBound: any;
     noDocking: boolean;
@@ -27,14 +27,12 @@ export class Dialog implements IContextMenuProvider {
     focusHandler: EventHandler;
     grayoutParent: PanelContainer;
 
-    static defaultResizeDirection: ResizeDirection = ResizeDirection.All & ~ResizeDirection.NorthEast;
-
-    constructor(panel: PanelContainer, dockManager: DockManager, grayoutParent?: PanelContainer, resizeDirection?: ResizeDirection) {
+    constructor(panel: PanelContainer, dockManager: DockManager, grayoutParent?: PanelContainer, disableResize?: boolean) {
         this.panel = panel;
         this.dockManager = dockManager;
         this.eventListener = dockManager;
         this.grayoutParent = grayoutParent;
-        this.resizeDirection = resizeDirection ?? Dialog.defaultResizeDirection;
+        this.disableResize = disableResize;
         this._initialize();
         this.dockManager.context.model.dialogs.push(this);
         this.position = dockManager.defaultDialogPosition;
@@ -57,7 +55,12 @@ export class Dialog implements IContextMenuProvider {
         this.elementDialog.tabIndex = 0;
         this.elementDialog.appendChild(this.panel.elementPanel);
         this.draggable = new DraggableContainer(this, this.panel, this.elementDialog, this.panel.elementTitle);
-        this.resizable = new ResizableContainer(this, this.draggable, this.draggable.topLevelElement, this.resizeDirection);
+
+        const resizeDirection: ResizeDirection = this.disableResize
+            ? ResizeDirection.None
+            : ResizeDirection.All & ~ResizeDirection.NorthEast;
+            
+        this.resizable = new ResizableContainer(this, this.draggable, this.draggable.topLevelElement, resizeDirection);
 
         this.dockManager.config.dialogRootElement.appendChild(this.elementDialog);
         this.elementDialog.classList.add('dialog-floating');

page/demo/ide/demo.js

@@ -8,7 +8,6 @@ import { DockModel } from "./DockModel.js";
 import { DockNode } from "./DockNode.js";
 import { DockWheel } from "./DockWheel.js";
 import { PanelType } from "./enums/PanelType.js";
-import { ResizeDirection } from "./enums/ResizeDirection.js";
 import { EventHandler } from "./EventHandler.js";
 import { FillDockContainer } from "./FillDockContainer.js";
 import { IDockContainer } from "./interfaces/IDockContainer.js";
@@ -372,7 +371,7 @@ export class DockManager {
         return this._requestDockContainer(referenceNode, container, this.layoutEngine.dockFill.bind(this.layoutEngine), false);
     }
 
-    floatDialog(container: PanelContainer, x: number, y: number, grayoutParent?: PanelContainer, resizeDirection?: ResizeDirection): Dialog {
+    floatDialog(container: PanelContainer, x: number, y: number, grayoutParent?: PanelContainer, disableResize?: boolean): Dialog {
         let retdiag = undefined;
 
         //check the dialog do not already exist
@@ -394,7 +393,7 @@ export class DockManager {
         let panel = container;
         Utils.removeNode(panel.elementPanel);
         panel.isDialog = true;
-        let dialog = new Dialog(panel, this, grayoutParent, resizeDirection);
+        let dialog = new Dialog(panel, this, grayoutParent, disableResize);
         dialog.setPosition(x, y);
         return dialog;
     }
@@ -520,9 +519,9 @@ export class DockManager {
      * Opens a Element in a Dialog
      * It is assumed that only leaf nodes (panels) can be undocked
      */
-    openInDialog(container: PanelContainer, event, dragOffset: Point, resizeDirection?: ResizeDirection) {
+    openInDialog(container: PanelContainer, event, dragOffset: Point, disableResize?: boolean) {
         // Create a new dialog window for the undocked panel
-        let dialog = new Dialog(container, this, null, resizeDirection);
+        let dialog = new Dialog(container, this, null, disableResize);
 
         if (event != null) {
             // Adjust the relative position