Update faas-cli new to use stack.yaml as a default #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates faas-cli new to create a stack.yaml file instead of a YAML file named after the function. This is to help users discover that stack.yaml does not require a --yaml or -f flag which can become cumbersome. When a stack.yaml or the file specified via -f already exists the new command will now prompt users to use --append Convert to SHA256 signatures for the invoke command This is a convenience option for invoking functions along with a signature, if a function accepts one. They should all have been moved to sha256 now if they were even using it Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
alexellis
force-pushed
the
new_defaults_to_stack_yaml
branch
from
8f52b97 to
6b02a9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
faas-cli newto use stack.yaml as a defaultUpdates faas-cli new to create a stack.yaml file instead of a YAML file named after the function. This is to help users discover that stack.yaml does not require a --yaml or -f flag which can become cumbersome.
When a stack.yaml or the file specified via -f already exists the new command will now prompt users to use
--appendAdditional changes:
Motivation and Context
Requested a number of times over the years, I also find it more convenient to work from a file where a separate
-fparameter isn't needed for each commandHow Has This Been Tested?
Various manual tests and the unit tests needed updates since there were test tables which wrote out different names which started to conflict with the new behaviour described.
Types of changes
Checklist:
Certain blog posts may need an update if there are any commands such as
mv fn.yml stack.yml, which could be tricky to find. Perhaps a regex in the docs and the website would be a good starting point.