Cant install id3lib

[xsteadfastx]

Maybe someone has an idea... i cant get id3lib installed... its needed for the wonderful abcde.

field_string_unicode.cpp: In member function 'virtual size_t ID3_FieldImpl::Get(unicode_t*, size_t) const':                                                                                                                                           [15/1718]
field_string_unicode.cpp:102:5: error: '::memcpy' has not been declared
     ::memcpy((void *)buffer, (void *)_text.data(), length * 2);
     ^
field_string_unicode.cpp: In member function 'virtual size_t ID3_FieldImpl::Get(unicode_t*, size_t, size_t) const':
field_string_unicode.cpp:151:7: error: '::memcpy' has not been declared
       ::memcpy(buffer, text, length * 2);
       ^
Makefile:585: recipe for target 'c_wrapper.lo' failed
make[1]: *** [c_wrapper.lo] Error 1
Makefile:585: recipe for target 'frame_impl.lo' failed
make[1]: *** [frame_impl.lo] Error 1
Makefile:585: recipe for target 'field.lo' failed
make[1]: *** [field.lo] Error 1
Makefile:585: recipe for target 'field_string_unicode.lo' failed
make[1]: *** [field_string_unicode.lo] Error 1
Makefile:585: recipe for target 'field_integer.lo' failed
make[1]: *** [field_integer.lo] Error 1
libtool: compile:  g++-5 -DHAVE_CONFIG_H -I. -I.. -I../include/id3 -I../include -g -O2 -Wall -Wno-unused -Wno-inline -Woverloaded-virtual -Wmissing-declarations -c frame.cpp -o frame.o >/dev/null 2>&1
libtool: compile:  g++-5 -DHAVE_CONFIG_H -I. -I.. -I../include/id3 -I../include -g -O2 -Wall -Wno-unused -Wno-inline -Woverloaded-virtual -Wmissing-declarations -c field_binary.cpp -o field_binary.o >/dev/null 2>&1
make[1]: Leaving directory '/tmp/id3lib-20201110-1099-1usdf4n/id3lib-3.8.3/src'
Makefile:448: recipe for target 'install-recursive' failed
make: *** [install-recursive] Error 1

==> Formula
Path: /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/id3lib.rb
==> Configuration
HOMEBREW_VERSION: 2.5.9-39-g49bb256
ORIGIN: https://github.com/Homebrew/brew
HEAD: 49bb2561aad7c1956ecfb9391bb924b81df23718
Last commit: 4 hours ago
Core tap ORIGIN: https://github.com/Homebrew/linuxbrew-core
Core tap HEAD: dc4883fc1693eb2f4a9065719f1af01056e0a340
Core tap last commit: 5 hours ago
Core tap branch: master
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: :0
HOMEBREW_EDITOR: nvim
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 8
Homebrew Ruby: 2.6.3 => /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/bin/ruby
CPU: octa-core 64-bit skylake
Clang: N/A
Git: 2.17.1 => /usr/bin/git
Curl: 7.58.0 => /usr/bin/curl
Kernel: Linux 4.15.0-1100-oem x86_64 GNU/Linux
OS: Ubuntu 18.04 LTS (beaver-three-eyed-raven X92) (bionic)
Host glibc: 2.27
/usr/bin/gcc: 7.5.0
/usr/bin/ruby: N/A
glibc: N/A
gcc: 5.5.0_7
xorg: N/A
==> ENV
HOMEBREW_CC: gcc-5
HOMEBREW_CXX: g++-5
MAKEFLAGS: -j8
CMAKE_PREFIX_PATH: /home/linuxbrew/.linuxbrew
HOMEBREW_GIT: git
ACLOCAL_PATH: /home/linuxbrew/.linuxbrew/share/aclocal
PATH: /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/shims/linux/super:/home/linuxbrew/.linuxbrew/opt/autoconf/bin:/home/linuxbrew/.linuxbrew/opt/automake/bin:/home/linuxbrew/.linuxbrew/opt/libtool/bin:/home/linuxbrew/.linuxbrew/opt/binutils/bin:/us
r/bin:/bin:/usr/sbin:/sbin:/home/linuxbrew/.linuxbrew/opt/gcc/bin

[xsteadfastx]

i tried it in a fresh debian:stable container with exactly the same error... so i think its reproducable.

[jonchang]

To be frank, id3lib requires so many patches that we would probably just remove this formula rather than trying to fix it yet again. It's not maintained upstream and only three other formulae depend on it with very low install counts. You're welcome to try to patch it yourself though, and we would of course consider any pull requests.

[xsteadfastx]

i read that its possible to use eye-d3 in abcde instead.... i will try it right now... id3lib is only needed if you want to tag mp3s with a older version of id3tags:

# mp3 tagging:
# There are three ways to tag MP3 files:
#   1. id3v1 (with id3)
#   2. id3v2.3 (with id3v2)
#   3. id3v2.4 (with eyeD3) This is the default
# Use ID3TAGV to select one of the older formats:
#ID3TAGV=id3v2.4
#ID3OPTS=
#ID3V2OPTS=
#EYED3OPTS="--set-encoding=utf16-LE"

[xsteadfastx]

here is my PR https://github.com/Homebrew/linuxbrew-core/pull/21422

its my first one... i just dont know if im doing it right.

[hyuraku]

here is my PR Homebrew/linuxbrew-core#21422

its my first one... i just dont know if im doing it right.

Homebrew/homebrew-core#64798 from Homebrew/linuxbrew-core#21422 was committed to master.