Developing a new formula, oasis-cli, trouble with brew install --interactive oasis-cli

[valentinbud]

Output of brew config

HOMEBREW_VERSION: 3.6.21-71-g1cf53b4
ORIGIN: https://github.com/Homebrew/brew
HEAD: 1cf53b4281e7bc22a8d7fc915fc6ba4576f8ef88
Last commit: 4 hours ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 5f03267485e99f4f8cba6d3268cc09d006fb79d8
Core tap last commit: 2 hours ago
Core tap branch: master
Core tap JSON: 11 Feb 14:19 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 12
HOMEBREW_NO_INSTALL_CLEANUP: set
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: dodeca-core 64-bit kabylake
Clang: 14.0.0 build 1400
Git: 2.39.1 => /usr/local/bin/git
Curl: 7.85.0 => /usr/bin/curl
macOS: 13.1-x86_64
CLT: 14.2.0.0.1.1668646533
Xcode: N/A

Output of brew doctor

Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed kegs have no formulae!
This means they were either deleted or installed manually.
You should find replacements for the following formulae:
  unrar

Warning: Unbrewed dylibs were found in /usr/local/lib.
If you didn't put them there on purpose they could cause problems when
building Homebrew formulae, and may need to be deleted.

Unexpected dylibs:
  /usr/local/lib/ss_conn_lib2.dylib

Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause formulae that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  terraform
  hyperkit
  docutils
  pyyaml
  six
  virtualenv

Warning: You have uncommitted modifications to Homebrew/homebrew-core.
If this is a surprise to you, then you should stash these modifications.
Stashing returns Homebrew to a pristine state but can be undone
should you later need to do so for some reason.
  cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core && git stash -u && git clean -d -f

Uncommitted files:
  ?? Formula/oasis-cli.rb

Description of issue

Hello everyone,

I am trying to add a new formula for oasisprotocol/cli
in Homebrew/homebrew-core. For that I have followed the
Formula Cookbook.

This is my first formula ever, so please bare with me.

I have done the following steps in order to achieve the above.

1. brew update
2. brew create --go --set-name oasis-cli https://github.com/oasisprotocol/cli/archive/refs/tags/v0.1.0.tar.gz
3. I have updated oasis-cli.rb to look like the following

class OasisCli < Formula
  desc "The official command-line interface (CLI) for interacting with the Oasis Network."
  version "0.1.0"
  homepage "https://oasisprotocol.org/"
  url "https://github.com/oasisprotocol/cli/archive/refs/tags/v0.1.0.tar.gz"
  sha256 "166d3b42fbec95d44b57eb19ebe65100d9b53b2ed45b4cb85409fdc06f8379a1"
  license "Apache-2.0"
  head "https://github.com/oasisprotocol/cli.git", branch: "master"

  depends_on "go" => :build

  def install
    system "go", "build", *std_go_args(ldflags: "-s -w -X github.com/oasisprotocol/cli/version.Software=v#{version}")
  end

  test do
    output = shell_output("#{bin}/oasis-cli --help 2>&1", 1)
    assert_match "CLI for interacting with the Oasis network", output

    output = shell_output("#{bin}/oasis-cli accounts 2>&1", 1)
    assert_match "Account operations", output

    output = shell_output("#{bin}/oasis-cli network 2>&1", 1)
    assert_match "Manage network endpoints", output
  end
end

4. I've ran brew install --interactive oasis-cli to check the build system as specified in the docs. Here I receive the following error

==> Fetching oasis-cli
curl: (22) The requested URL returned error: 404

Error: Failure while executing; `/usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/3.6.21-71-g1cf53b4\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 13.1\)\ curl/7.85.0 --header Accept-Language:\ en --fail --progress-bar --retry 3 --location --remote-time --output /Users/valentinbud/Library/Caches/Homebrew/Formula/oasis-cli.rb https://raw.githubusercontent.com/Homebrew/homebrew-core/5f03267485e99f4f8cba6d3268cc09d006fb79d8/Formula/oasis-cli.rb` exited with 22. Here's the output:
curl: (22) The requested URL returned error: 404

From my understanding the command is trying to download oasis-cli.rb from the Homebrew/homebrew-core repository
and fails with 404, which is normal because I have yet to commit the code and open a PR.

I thought that maybe the above command is ok to fail. I now think/know I've made a wrong assumption.
Nonetheless I have moved on to the next step.

5. brew install --build-from-source --verbose --debug oasis-cli
   The above command fails with the same 404.

 /usr/local/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaLoader): loading /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/oasis-cli.rb
/usr/local/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaAPILoader): loading go from API
==> Fetching oasis-cli
/usr/local/Homebrew/Library/Homebrew/shims/shared/git --version
/usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/3.6.21-71-g1cf53b4\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 13.1\)\ curl/7.85.0 --header Accept-Language:\ en --fail --retry 3 --location --remote-time --output /Users/valentinbud/Library/Caches/Homebrew/Formula/oasis-cli.rb https://raw.githubusercontent.com/Homebrew/homebrew-core/5f03267485e99f4f8cba6d3268cc09d006fb79d8/Formula/oasis-cli.rb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0    14    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404
Error: Failure while executing; `/usr/local/Homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/3.6.21-71-g1cf53b4\ \(Macintosh\;\ Intel\ Mac\ OS\ X\ 13.1\)\ curl/7.85.0 --header Accept-Language:\ en --fail --retry 3 --location --remote-time --output /Users/valentinbud/Library/Caches/Homebrew/Formula/oasis-cli.rb https://raw.githubusercontent.com/Homebrew/homebrew-core/5f03267485e99f4f8cba6d3268cc09d006fb79d8/Formula/oasis-cli.rb` exited with 22. Here's the output:
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0    14    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404

/usr/local/Homebrew/Library/Homebrew/system_command.rb:302:in `assert_success!'
/usr/local/Homebrew/Library/Homebrew/utils/curl.rb:166:in `curl'
/usr/local/Homebrew/Library/Homebrew/utils/curl.rb:199:in `curl_download'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:432:in `load_file'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:326:in `klass'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:321:in `get_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:578:in `factory'
/usr/local/Homebrew/Library/Homebrew/formula_installer.rb:1186:in `fetch'
/usr/local/Homebrew/Library/Homebrew/install.rb:313:in `block in install_formulae'
/usr/local/Homebrew/Library/Homebrew/install.rb:284:in `map'
/usr/local/Homebrew/Library/Homebrew/install.rb:284:in `install_formulae'
/usr/local/Homebrew/Library/Homebrew/cmd/install.rb:226:in `install'
/usr/local/Homebrew/Library/Homebrew/brew.rb:93:in `<main>'

I have read the Formula Cookbook a couple of times but I don't understand what am I missing.
Could someone please help me troubleshoot/fix this? Thank you.

[gromgit]

From my understanding the command is trying to download oasis-cli.rb from the Homebrew/homebrew-core repository
and fails with 404, which is normal

That's actually not normal, if you think about it.

export HOMEBREW_NO_INSTALL_FROM_API=1 and try again.

[valentinbud]

Thank you @gromgit! That did the trick. And yes, I agree, that's actually not normal at all.

I actually meant that the 404 is normal since oasis-cli.rb is not yet available in the repository.

I'll look for a way to update the Formula Cookbook with this information so other newcomers
don't have the same issue as me.

[gromgit]

No need for now. Homebrew is currently going through a transition to "install from API by default"; you're just seeing teething problems that are surfacing:

• https://github.com/search?q=org%3AHomebrew+homebrew_no_install_from_api&type=issues
• https://github.com/search?q=org%3AHomebrew+homebrew_no_install_from_api&type=discussions

[valentinbud]

Ok. Thank you for the information and your help.