WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit 6d8971e

Browse files
committed
Added navigation target constant.
1 parent c744e0e commit 6d8971e

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/workshops/page/ko/pageHyperlinkDetails.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import * as ko from "knockout";
22
import template from "./pageHyperlinkDetails.html";
33
import { Component, Param, Event, OnMounted } from "@paperbits/common/ko/decorators";
44
import { HyperlinkModel } from "@paperbits/common/permalinks";
5+
import { NavigationTarget } from "@paperbits/common/html";
56

67

78
@Component({
@@ -23,7 +24,7 @@ export class PageHyperlinkDetails {
2324

2425
@OnMounted()
2526
public async initialize(): Promise<void> {
26-
this.target(this.hyperlink.target || "_self");
27+
this.target(this.hyperlink.target || NavigationTarget.Self);
2728
this.target.subscribe(this.applyChanges);
2829
}
2930

src/workshops/page/ko/pageItem.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import * as ko from "knockout";
22
import { PageContract } from "@paperbits/common/pages/pageContract";
33
import { HyperlinkModel } from "@paperbits/common/permalinks";
44
import { SocialShareData } from "@paperbits/common/pages/socialShareData";
5+
import { NavigationTarget } from "@paperbits/common/html";
56

67
export class AnchorItem {
78
public title: string;
@@ -43,7 +44,7 @@ export class PageItem {
4344
public getHyperlink(): HyperlinkModel {
4445
const hyperlinkModel = new HyperlinkModel();
4546
hyperlinkModel.title = this.title();
46-
hyperlinkModel.target = "_self";
47+
hyperlinkModel.target = NavigationTarget.Self;
4748
hyperlinkModel.targetKey = this.key;
4849
hyperlinkModel.href = this.permalink();
4950

src/workshops/urls/ko/urlItem.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import * as ko from "knockout";
22
import { UrlContract } from "@paperbits/common/urls/urlContract";
33
import { HyperlinkModel } from "@paperbits/common/permalinks";
4+
import { NavigationTarget } from "@paperbits/common/html";
45

56
/**
67
* URL view model.
@@ -33,7 +34,7 @@ export class UrlItem {
3334
public getHyperlink(): HyperlinkModel {
3435
const hyperlinkModel = new HyperlinkModel();
3536
hyperlinkModel.title = this.title();
36-
hyperlinkModel.target = "_self";
37+
hyperlinkModel.target = NavigationTarget.Self;
3738
hyperlinkModel.targetKey = this.key;
3839
hyperlinkModel.href = this.permalink();
3940

0 commit comments

Comments
 (0)