Pointer cleanup for ease of use and better memory management

[spaulaus]

Description

Pointers abound in the software. It's often difficult to figure out who has ownership and who should be deleting. The only notes about ownership are in the comments; they may or may not reflect reality. We know that pointers are not being handled properly since long running executions of the program tend to gobble memory on laptops. I suspect that kqxhc doesn't see the issue because it has 64GB of RAM.

I've been reading up on unique pointers. Since we've fully adopted the C++11 standard, we should start to implement these where we can. These could help clear up these issues.

Development Platform

• Arch Linux
• Kernel : 4.9.11-1-ARCH
• Cmake : 3.6.3
• Gcc : 6.3.1 20170109
• gdb : 7.11.1

Work to be done

1. Determine where the offending pointers are.
2. Cleanup the code for better pointer management.
   1. Ensure that there's always a delete for every new.
   2. Ensure that we are not newing the same thing more than once, or that if we are we are deleting them.
3. More to be determined later.

Acceptance Criteria

1. The program is able to compile
2. The program can scan large files without eating all the memory on systems with limited memory resources.
3. The program is stable over long periods of time.

[spaulaus]

I have tested this with 1f5c39e using a135feb_12.ldf. The program starts to have issues 14% complete. It used up all of the memory on my laptop and things became sluggish. The program didn't crash, but it utilized all of the RAM and swap space. This suggests that there is an issue with the memory allocation.

[spaulaus]

I have tried scanning IS599Oct_A052_02.ldf and we get much farther than the previous ldf with no obvious memory related issues. There may be some sort of corruption in a135feb_12.ldf that we are not handling properly.