WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@sneridagh
Copy link
Member

No description provided.

@sneridagh sneridagh requested a review from ericof as a code owner July 8, 2024 11:16
@sneridagh
Copy link
Member Author

@ericof I polished the generator until I reached what I've found this morning:

https://github.com/plone/cookieplone-templates/actions/runs/9840829807/job/27165988173#step:15:15

If you run make check inside the backend folder, tox gets crazy and do not find the project.pytoml file.

Also in the backend, there's no make format, the check command is make check while in the frontend is make lint.

I kind of dislike that check also does format, because it leads to tons of confusion.

@stevepiercy
Copy link
Contributor

I recall that we abolished make check because it means "check code", not "reformat and write code". Let's burn it with 🔥. make lint or make format both make sense, depending on what the command actually does.

@sneridagh
Copy link
Member Author

I'm +1000 with @stevepiercy on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants