WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit 9804627

Browse files
tistostevepiercy
andauthored
Update plips.md: be more precise about mentioning teams to submit a PLIP (#1972)
* Update plips.md: be more precise about mentioning teams to submit a PLIP * Apply suggestions from code review * Update docs/contributing/core/plips.md --------- Co-authored-by: Steve Piercy <[email protected]>
1 parent 271ad22 commit 9804627

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

docs/contributing/core/plips.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,19 @@ You may revise your PLIP based on feedback.
9191
If you need help at any point in this process, you can either `@` the team or personally contact a member of the designated team.
9292

9393

94+
(team-approves-proposal-label)=
95+
9496
## Team approves proposal
9597

9698
After incorporating feedback to your proposal, you can request a final review and approval for inclusion in Plone.
97-
Every PLIP must be approved by the designated team.
99+
100+
You can do this by mentioning one of the appropriate {ref}`designated-teams-label`, with `@plone/framework-team` as the default if you're not certain.
101+
102+
Every PLIP must be approved by the designated team for work to be merged.
103+
104+
Although work may be started at any time, the PLIP may be revised many times or even rejected.
105+
Set expectations accordingly before starting work on the PLIP.
106+
In general, it's a good idea to wait for approval of the PLIP before starting work, but there are exceptions, such as creating a proof of concept to demonstrate what the PLIP would be designed to do, or you might need it for your own project anyway.
98107

99108

100109
## Implement your PLIP

0 commit comments

Comments
 (0)