From eeb03bc4cba05d68dc1ca41370692b64ce9034f7 Mon Sep 17 00:00:00 2001 From: Timo Stollenwerk Date: Wed, 17 Sep 2025 07:42:50 +0200 Subject: [PATCH 1/3] Update plips.md: be more precise about mentioning teams to submit a PLIP --- docs/contributing/core/plips.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/contributing/core/plips.md b/docs/contributing/core/plips.md index c7b8b17ebb..7d613657c3 100644 --- a/docs/contributing/core/plips.md +++ b/docs/contributing/core/plips.md @@ -90,12 +90,13 @@ You may revise your PLIP based on feedback. If you need help at any point in this process, you can either `@` the team or personally contact a member of the designated team. - ## Team approves proposal After incorporating feedback to your proposal, you can request a final review and approval for inclusion in Plone. -Every PLIP must be approved by the designated team. +You can do this by mentioning either one of the designated teams (@plone/Volto or @plone/ClassicUI or meantion @plone/framework-team if you are not sure if your PLIP is suited for a designated team. + +Every PLIP must be approved by the designated team. Once your PLIP has been approved by one of the three teams, you can start implementing your PLIP. ## Implement your PLIP From c035eda77065965dace977ec9bac1fc56957884d Mon Sep 17 00:00:00 2001 From: Steve Piercy Date: Mon, 1 Dec 2025 00:21:58 -0800 Subject: [PATCH 2/3] Apply suggestions from code review --- docs/contributing/core/plips.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/contributing/core/plips.md b/docs/contributing/core/plips.md index 7d613657c3..30fe93c57f 100644 --- a/docs/contributing/core/plips.md +++ b/docs/contributing/core/plips.md @@ -90,11 +90,14 @@ You may revise your PLIP based on feedback. If you need help at any point in this process, you can either `@` the team or personally contact a member of the designated team. + +(team-approves-proposal-label)= + ## Team approves proposal After incorporating feedback to your proposal, you can request a final review and approval for inclusion in Plone. -You can do this by mentioning either one of the designated teams (@plone/Volto or @plone/ClassicUI or meantion @plone/framework-team if you are not sure if your PLIP is suited for a designated team. +You can do this by mentioning one of the appropriate {ref}`designated-teams-label`, with `@plone/framework-team` as the default if you're not certain. Every PLIP must be approved by the designated team. Once your PLIP has been approved by one of the three teams, you can start implementing your PLIP. From 4eef7b8e9522053dea52ab79ea2992b1f35ed7be Mon Sep 17 00:00:00 2001 From: Steve Piercy Date: Thu, 18 Dec 2025 00:24:21 -0800 Subject: [PATCH 3/3] Update docs/contributing/core/plips.md --- docs/contributing/core/plips.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/contributing/core/plips.md b/docs/contributing/core/plips.md index 30fe93c57f..6fe38f3c6d 100644 --- a/docs/contributing/core/plips.md +++ b/docs/contributing/core/plips.md @@ -99,7 +99,12 @@ After incorporating feedback to your proposal, you can request a final review an You can do this by mentioning one of the appropriate {ref}`designated-teams-label`, with `@plone/framework-team` as the default if you're not certain. -Every PLIP must be approved by the designated team. Once your PLIP has been approved by one of the three teams, you can start implementing your PLIP. +Every PLIP must be approved by the designated team for work to be merged. + +Although work may be started at any time, the PLIP may be revised many times or even rejected. +Set expectations accordingly before starting work on the PLIP. +In general, it's a good idea to wait for approval of the PLIP before starting work, but there are exceptions, such as creating a proof of concept to demonstrate what the PLIP would be designed to do, or you might need it for your own project anyway. + ## Implement your PLIP