WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Replace browserDefault with is_default_page #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gforcada wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replace browserDefault with is_default_page #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cef33f
Configuring with plone.meta
gforcada Dec 6, 2025
490bb39
fix: use function from plone.base
gforcada Aug 17, 2025
ddb724a
Add news entry
gforcada Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/meta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ on:
jobs:
qa:
uses: plone/meta/.github/workflows/[email protected]
test:
uses: plone/meta/.github/workflows/[email protected]
coverage:
uses: plone/meta/.github/workflows/[email protected]
dependencies:
Expand Down
3 changes: 1 addition & 2 deletions .meta.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,14 @@
# See the inline comments on how to expand/tweak this configuration file
[meta]
template = "default"
commit-id = "2.2.0"
commit-id = "2.3.0"

[tox]
test_matrix = {"6.2" = ["*"]}

[github]
jobs = [
"qa",
"test",
"coverage",
"dependencies",
"release_ready",
Expand Down
1 change: 1 addition & 0 deletions news/+ignore.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use `plone.base`'s `is_default_page` rather than a plone skin @gforcada
4 changes: 4 additions & 0 deletions src/plone/app/content/browser/content_status_history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from plone.base import PloneMessageFactory as _
from plone.base.defaultpage import is_default_page
from plone.base.utils import human_readable_size
from plone.base.utils import is_expired
from Products.CMFCore.utils import getToolByName
Expand Down Expand Up @@ -135,6 +136,9 @@ def redirect_to_referrer(self):
def isExpired(self, content):
return is_expired(content)

def is_default_page(self, obj):
return is_default_page(self.context.__parent__, obj)

@deprecate(
"This method is deprecated since Plone 6, "
"use the @@plone/human_readable_size method instead"
Expand Down
3 changes: 1 addition & 2 deletions src/plone/app/content/browser/templates/content_status_history.pt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,7 @@
item_use_view python:item_type in use_view_action;
hasGetUrl python:hasattr(item.aq_explicit, 'getURL');
item_rel_url python:hasGetUrl and item.getURL(relative=1) or getRelativeContentURL(item);
browserDefaultResult context/browserDefault;
isBrowserDefault python:len(browserDefaultResult[1]) == 1 and item.id == context.browserDefault()[1][0];
isBrowserDefault python:view.is_default_page(item);
item_folderish item/is_folderish|nothing;
item_has_image python:item.getIcon;
"
Expand Down