fix: address linting issues in auto-delete feature

- Break long function signatures into multiple lines (base.go, entity_storage.go)
- Fix wsl issues by adding blank lines before if statements
- Pre-allocate slices in canDeleteSnapshot

Author: claude

engine/internal/cloning/base.go

@@ -519,12 +519,16 @@ func (c *Base) GetSnapshotMeta(id string) *SnapshotMeta {
 }
 
 // UpdateBranchMeta updates branch metadata.
-func (c *Base) UpdateBranchMeta(name string, protected *bool, deleteAt *models.LocalTime, autoDeleteMode *models.AutoDeleteMode) *BranchMeta {
+func (c *Base) UpdateBranchMeta(
+	name string, protected *bool, deleteAt *models.LocalTime, autoDeleteMode *models.AutoDeleteMode,
+) *BranchMeta {
 	return c.entityStorage.UpdateBranchMeta(name, protected, deleteAt, autoDeleteMode)
 }
 
 // UpdateSnapshotMeta updates snapshot metadata.
-func (c *Base) UpdateSnapshotMeta(id string, protected *bool, deleteAt *models.LocalTime, autoDeleteMode *models.AutoDeleteMode) *SnapshotMeta {
+func (c *Base) UpdateSnapshotMeta(
+	id string, protected *bool, deleteAt *models.LocalTime, autoDeleteMode *models.AutoDeleteMode,
+) *SnapshotMeta {
 	return c.entityStorage.UpdateSnapshotMeta(id, protected, deleteAt, autoDeleteMode)
 }
 

engine/internal/cloning/entity_storage.go

@@ -163,7 +163,9 @@ func (es *EntityStorage) SetBranchMeta(meta *BranchMeta) {
 }
 
 // UpdateBranchMeta updates existing branch metadata or creates new one.
-func (es *EntityStorage) UpdateBranchMeta(name string, protected *bool, deleteAt *models.LocalTime, autoDeleteMode *models.AutoDeleteMode) *BranchMeta {
+func (es *EntityStorage) UpdateBranchMeta(
+	name string, protected *bool, deleteAt *models.LocalTime, autoDeleteMode *models.AutoDeleteMode,
+) *BranchMeta {
 	es.branchMutex.Lock()
 	defer es.branchMutex.Unlock()
 
@@ -229,7 +231,9 @@ func (es *EntityStorage) SetSnapshotMeta(meta *SnapshotMeta) {
 }
 
 // UpdateSnapshotMeta updates existing snapshot metadata or creates new one.
-func (es *EntityStorage) UpdateSnapshotMeta(id string, protected *bool, deleteAt *models.LocalTime, autoDeleteMode *models.AutoDeleteMode) *SnapshotMeta {
+func (es *EntityStorage) UpdateSnapshotMeta(
+	id string, protected *bool, deleteAt *models.LocalTime, autoDeleteMode *models.AutoDeleteMode,
+) *SnapshotMeta {
 	es.snapshotMutex.Lock()
 	defer es.snapshotMutex.Unlock()
 

engine/internal/srv/auto_delete.go

@@ -81,6 +81,7 @@ func (s *Server) processExpiredBranches(ctx context.Context) {
 				continue
 			case models.AutoDeleteForce:
 				log.Msg(fmt.Sprintf("Force deleting branch %q: %s", meta.Name, reason))
+
 				if err := s.forceDeleteBranch(ctx, fsm, meta.Name); err != nil {
 					log.Errf("failed to force delete branch %q: %v", meta.Name, err)
 					continue
@@ -158,6 +159,7 @@ func (s *Server) forceDeleteBranch(ctx context.Context, fsm pool.FSManager, bran
 
 func (s *Server) getClonesForSnapshot(snapshotID string) []string {
 	state := s.Cloning.GetCloningState()
+
 	var cloneIDs []string
 
 	for _, clone := range state.Clones {
@@ -212,6 +214,7 @@ func (s *Server) processExpiredSnapshots(ctx context.Context) {
 				continue
 			case models.AutoDeleteForce:
 				log.Msg(fmt.Sprintf("Force deleting snapshot %q: %s", meta.ID, reason))
+
 				if err := s.forceDeleteSnapshot(ctx, fsm, meta.ID, cloneIDs); err != nil {
 					log.Errf("failed to force delete snapshot %q: %v", meta.ID, err)
 					continue
@@ -251,8 +254,8 @@ func (s *Server) canDeleteSnapshot(fsm pool.FSManager, meta *cloning.SnapshotMet
 		return false, fmt.Sprintf("failed to check dependencies: %v", err), nil
 	}
 
-	var cloneIDs []string
-	var protectedClones []string
+	cloneIDs := make([]string, 0, len(dependentCloneDatasets))
+	protectedClones := make([]string, 0)
 
 	for _, cloneDataset := range dependentCloneDatasets {
 		cloneID, ok := branching.ParseCloneName(cloneDataset, poolName)