WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@gravelg
Copy link
Contributor

@gravelg gravelg commented Nov 14, 2025

The targeting also needs to be added to seatbid[].bid[]

@gravelg gravelg requested a review from scr-oath November 17, 2025 15:57
@bsardo bsardo changed the title fix: also put scope3 rtd targeting in seatbid Scope3: Add rtd targeting in seatbid Nov 19, 2025
@bsardo bsardo added the module label Nov 19, 2025
scr-oath
scr-oath previously approved these changes Nov 21, 2025
Copy link
Contributor

@scr-oath scr-oath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gravelg - we also require lint to pass; please fix these issues - you can run yourself with the supplied command.

[scr@MacBook-Pro-3]$ go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest run ./modules/scope3/rtd/...
go: downloading github.com/golangci/golangci-lint/v2 v2.7.1
modules/scope3/rtd/async_request.go:51:28: QF1008: could remove embedded field "Module" from selector (staticcheck)
                ar.Segments, ar.Err = ar.Module.fetchScope3Segments(ar.Context, request)
                                         ^
modules/scope3/rtd/module.go:407:5: S1009: should omit nil check; len() for nil slices is defined as zero (staticcheck)
        if scope3Resp.AEESignals.Include != nil && len(scope3Resp.AEESignals.Include) > 0 {
           ^
modules/scope3/rtd/module.go:408:74: QF1008: could remove embedded field "AEESignals" from selector (staticcheck)
                segmentsStr := scope3IncludeKeyPlusSeparator + strings.Join(scope3Resp.AEESignals.Include, ",")
                                                                                       ^
modules/scope3/rtd/module.go:411:16: QF1008: could remove embedded field "AEESignals" from selector (staticcheck)
        if scope3Resp.AEESignals.Macro != "" {
                      ^
modules/scope3/rtd/module.go:412:70: QF1008: could remove embedded field "AEESignals" from selector (staticcheck)
                segments = append(segments, scope3MacroKeyPlusSeparator+scope3Resp.AEESignals.Macro)
                                                                                   ^
5 issues:
* staticcheck: 5
exit status 1

@scr-oath scr-oath self-requested a review December 5, 2025 16:48
@scr-oath scr-oath self-requested a review December 5, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants