document battle regulations #833
Conversation
src/battle_regulation.c
Outdated
|
|
||
| if (index < NELEMS(BattleRegulation_PredefinedRules)) { | ||
| messageLoader = MessageLoader_Init(MSG_LOADER_PRELOAD_ENTIRE_BANK, NARC_INDEX_MSGDATA__PL_MSG, TEXT_BANK_UNK_0353, heapID); | ||
| MessageLoader_GetStrbuf(messageLoader, 70 + index, strbuf); |
There was a problem hiding this comment.
polish: Use a constant-ref from the text-bank header for 70.
src/battle_regulation_validation.c
Outdated
| HeightWeightData *HeightWeightData_Load(enum HeapID heapID) | ||
| { | ||
| HeightWeightData *data = Pokedex_HeightWeightData(heapID); | ||
| Pokedex_HeightWeightData_Load(data, FALSE, heapID); | ||
| return data; | ||
| } | ||
|
|
||
| void HeightWeightData_Free(HeightWeightData *heightWeightData) | ||
| { | ||
| Pokedex_HeightWeightData_Release(heightWeightData); | ||
| Pokedex_HeightWeightData_Free(heightWeightData); | ||
| } |
There was a problem hiding this comment.
thought: Should we separate these into their own TU, if that matches?
There was a problem hiding this comment.
maybe. they're general-use functions in a vacuum, but in practice are only ever used for HeightWeightData that get passed into other functions in this file. an alternative could be renaming them to BattleRegulation_(Load/Free)HeightWeightData
splitting them out does still match, fwiw
There was a problem hiding this comment.
I think tying them to regulation is probably a mistake.
they're general-use functions in a vacuum, but in practice are only ever used for HeightWeightData that get passed into other functions in this file.
You certain about that? There are some instances in party_menu/main.c.
lhearachel
left a comment
lhearachel
left a comment
There was a problem hiding this comment.
Pending merge conflicts
scbroede
force-pushed
the
battle_regulation
branch
from
8f23bf3 to
966f0f5
Compare
3 participants
rebase of #775 with pr feedback addressed