Refactor Makefile logic for locating keymaps #25808
Merged
+67
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
force-pushed
the
refactor_make_locate_keymap
branch
from
47f5f22 to
69a44ff
Compare
zvecr
force-pushed
the
refactor_make_locate_keymap
branch
from
69a44ff to
76a9ca4
Compare
drashna
approved these changes
Dec 4, 2025
filterpaper
approved these changes
Dec 7, 2025
zvecr
changed the title
zvecr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #25802, the fragmentation of logic made implementing a fix more of a chore than it should have been.
This PR aims to simplify the logic so that its not spread across multiple files and consistent with the corresponding CLI logic.
Types of Changes
Issues Fixed or Closed by This PR
Checklist