WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@zvecr
Copy link
Member

@zvecr zvecr commented Dec 2, 2025

Description

When the CI Build Major Branch workflow runs on master/develop, it attempts to find xap keymaps. As the feature is still on its own branch, zero keymaps are found. These targets are then passed to qmk mass-compile. In the case of zero keymaps, qmk mass-compile is then given zero additional target arguments and in turn builds everything.

This additional build should be avoided as it is both extremely slow, and completely unnecessary due to it already building in batches.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the CI label Dec 2, 2025
@zvecr zvecr changed the title Update ci_build_major_branch_keymap.yml Handle building of XAP keymaps on master/develop Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants