fix(QDialog): restore scroll after close if only hash/query changed #… #18190
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranchfix: #18185)Description / What problem is solved:
QDialog does not restore scroll position if the URL hash or query parameters change while the dialog is open.
Currently, scroll is restored only if
window.location.href === href, which fails when only hash/query changes.This change updates the check to compare only the route path (
window.location.pathname) instead of the full URL.Scroll is now restored correctly after closing the dialog if the route path has not changed.
Code change: