drivers: media: bcm2835_isp: Cache LS table dmabuf #6429
Merged
+46
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6by9
reviewed
Oct 22, 2024
Clients such as libcamera do not change the LS table dmabuf on every frame. In such cases instead of mapping/remapping the same dmabuf on every frame to send to the firmware, cache the dmabuf once and only update and remap if the dmabuf has been changed by the userland client. Signed-off-by: Naushir Patuck <[email protected]>
Contributor
Author
|
@6by9 I think this is ready to merge if you are happy with the changes. |
Contributor
|
Not the easiest to read on a phone, but it looks OK. |
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 1, 2024
kernel: drivers: media: bcm2835_isp: Cache LS table dmabuf See: raspberrypi/linux#6429 kernel: arm64: dts: Sort out CM5 and I/O board I2C ports See: raspberrypi/linux#6441 kernel: cgroup: Use kernel command line to disable memory cgroup See: raspberrypi/linux#6439
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 1, 2024
kernel: drivers: media: bcm2835_isp: Cache LS table dmabuf See: raspberrypi/linux#6429 kernel: arm64: dts: Sort out CM5 and I/O board I2C ports See: raspberrypi/linux#6441 kernel: cgroup: Use kernel command line to disable memory cgroup See: raspberrypi/linux#6439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients such as libcamera do not change the LS table dmabuf on every frame. In such cases instead of mapping/remapping the same dmabuf on every frame to send to the firmware, cache the dmabuf once and only update and remap if the dmabuf has been changed by the userland client.