Minify cause errors with Express routes

[throrin19]

Reproduction link or steps

Hello, It is really compicated to me to set this project, this is a private project inside a big monorepo.

So, I use express v5 and I try to launch builded code. When I use tsdown without minify, all is good. When I run with minify code, all express routes return 404 with no reason (I have no exception in my code).
I think minify part rewrite all express regexp part to retrieve routes.

What is expected?

All express routes return 404 when code is minify

What is actually happening?

All works fine with or without minify enabled

Any additional comments?

This is my tsdown config :

import { defineConfig } from 'tsdown';

export default defineConfig({
    entry: ['index.ts'],
    external: ['pg', 'pg-query-stream', 'better-sqlite3', 'tedious', 'mysql', 'oracledb', 'sqlite3'],
    format: 'esm',
    minify: true,
    nodeProtocol: true,
    noExternal: [/^(?!(pg|better-sqlite3|tedious|mysql|oracledb|sqlite3)).*$/],
    platform: 'node',
    shims: true,
    sourcemap: true,
    treeshake: true,
    tsconfig: 'tsconfig.json',
    watch: false,
});

[sxzz]

Sorry but without mini reproduction, we're really unable to reproduce it quickly. Please provide a minimal reproduction. Thanks.

Why reproduction is required

[mhdeeb]

@sxzz Here is a mini reproduction.

package.json:

{
  "dependencies": {
    "express": "^5.1.0"
  }
}

index.ts:

import express from 'express';


const app = express();
const port = 5010;

app.get('/hello', (req, res) => {
  res.send('Hello, World!');
});

app.listen(port);

build:

npm i
npx tsdown --noExternal express --minify index.ts

run:

node ./dist/index.mjs

Note:

I get when running

(node:52534) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
(Use `node --trace-deprecation ...` to show where the warning was created)

And I notice that routes have a missing initial character by the time they hit the middleware.

[ocavue]

@mhdeeb Sorry, I cannot reproduce this issue with your code. Please provide a full GitHub repo or a https://stackblitz.com/ link for your reproduction.

Also worth mentioning, it's better to move express into the dependencies field in your package.json, compared to using --noExternal express.