WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Rework Payload API and Behavior #793

@OlegDokuka

Description

@OlegDokuka

Payload API has inconsistent and absolutely confusing behavior:

##Expected
case 1

var p = ByteBufPayload.create(data, Unpooled.EMPTY)
assertTrue(p.hasMetadata())
assertEqueals(p.metadata(), Unpooled.EMPTY) 

Unexpected

case 2

var p = ByteBufPayload.create(data, null)
assertFalse(p.hasMetadata())
assertNull(p.metadata()) // fails because Payload always returns Unpooled.EMPTY

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking changesChanges that break API or behaviournew APIrefactoringsChanges that does not affect API and behaviour

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions