fix(info): default to local without explicit reg (#16358)

### What does this PR try to resolve?

close #16145

[`93c2c40`
(#16358)](93c2c40)
shouldn't be an error; it should inspect the local package correctly.

The reason it is buggy is as follows: The `default_registry` function
attempts to retrieve the default registry from the user's configuration;
in this case, it is crates-io.
```rust
in src/cargo/ops/registry/mod.rs:210-248(get_source_id_with_package_id):

  (Some(reg_or_index), Some(package_id)) => {
      let sid = get_initial_source_id_from_registry_or_index(gctx,
  reg_or_index)?;  // crates-io
      let package_source_id = package_id.source_id();  // local path source
      // Check if they match or if one replaces the other
      if sid == package_source_id  // false: crates-io != path
          || is_replacement_for_package_source(gctx, sid,
  package_source_id)?  // false: no replacement for local path
      {
          (true, package_source_id)
      } else {
          (false, sid)  // <-- Returns this: "don't use local package,
  search in registry"
      }
  }
```
In this PR, I modified the cargo-info to prefer the local package if the
registry is not explicitly specified.

### How to test and review this PR?

Check the unit test.
1. One case for reproducing the described issue. It shouldn't be an
error. We should inspect the local package properly.
2. Another case specifies the registry configured in the config file to
ensure we can search the registry correctly.

r? @ghost

Author: epage

src/bin/cargo/commands/info.rs

@@ -29,7 +29,9 @@ pub fn exec(gctx: &mut GlobalContext, args: &ArgMatches) -> CliResult {
     let spec = PackageIdSpec::parse(package)
         .with_context(|| format!("invalid package ID specification: `{package}`"))?;
 
+    // Check if --registry or --index was explicitly provided
+    let explicit_registry = args._contains("registry") || args._contains("index");
     let reg_or_index = args.registry_or_index(gctx)?;
-    info(&spec, gctx, reg_or_index)?;
+    info(&spec, gctx, reg_or_index, explicit_registry)?;
     Ok(())
 }

src/cargo/ops/registry/info/mod.rs

@@ -20,6 +20,7 @@ pub fn info(
     spec: &PackageIdSpec,
     gctx: &GlobalContext,
     reg_or_index: Option<RegistryOrIndex>,
+    explicit_registry: bool,
 ) -> CargoResult<()> {
     let source_config = SourceConfigMap::new(gctx)?;
     let mut registry = PackageRegistry::new_with_source_config(gctx, source_config)?;
@@ -39,8 +40,17 @@ pub fn info(
             .and_then(|path| ws.members().find(|p| p.manifest_path() == path))
     });
     let (mut package_id, is_member) = find_pkgid_in_ws(nearest_package, ws.as_ref(), spec);
+
+    // If a local package exists and no explicit registry/index was provided,
+    // prefer the local package over the default registry
+    let reg_or_index_to_use = if package_id.is_some() && !explicit_registry {
+        None
+    } else {
+        reg_or_index.as_ref()
+    };
+
     let (use_package_source_id, source_ids) =
-        get_source_id_with_package_id(gctx, package_id, reg_or_index.as_ref())?;
+        get_source_id_with_package_id(gctx, package_id, reg_or_index_to_use)?;
     // If we don't use the package's source, we need to query the package ID from the specified registry.
     if !use_package_source_id {
         package_id = None;

tests/testsuite/cargo_info/mod.rs

@@ -17,6 +17,8 @@ mod specify_version_within_ws_and_conflict_with_lockfile;
 mod specify_version_within_ws_and_match_with_lockfile;
 mod transitive_dependency_within_ws;
 mod verbose;
+mod with_default_registry_configured;
+mod with_default_registry_configured_and_specified;
 mod with_frozen_outside_ws;
 mod with_frozen_within_ws;
 mod with_locked_outside_ws;

tests/testsuite/cargo_info/with_default_registry_configured/in/.cargo/config.toml

@@ -0,0 +1,2 @@
+[registry]
+default = "crates-io"

tests/testsuite/cargo_info/with_default_registry_configured/in/Cargo.lock

@@ -0,0 +1,9 @@
+[workspace]
+members = ["crates/*"]
+
+[package]
+name = "foo"
+version = "0.0.0"
+
+[dependencies]
+crate1 = { path = "./crates/crate1" }

tests/testsuite/cargo_info/with_default_registry_configured/in/Cargo.toml

@@ -0,0 +1,5 @@
+[package]
+name = "crate1"
+version = "0.0.0"
+
+[dependencies]

tests/testsuite/cargo_info/with_default_registry_configured/in/crates/crate1/Cargo.toml

@@ -0,0 +1 @@
+

tests/testsuite/cargo_info/with_default_registry_configured/in/crates/crate1/src/lib.rs

@@ -0,0 +1 @@
+

tests/testsuite/cargo_info/with_default_registry_configured/in/src/lib.rs

@@ -0,0 +1,24 @@
+use crate::prelude::*;
+use cargo_test_support::{Project, compare::assert_ui, current_dir, file};
+
+use super::init_registry_without_token;
+
+#[cargo_test]
+fn case() {
+    init_registry_without_token();
+
+    let project = Project::from_template(current_dir!().join("in"));
+    let project_root = project.root();
+    let cwd = &project_root;
+
+    snapbox::cmd::Command::cargo_ui()
+        .arg("info")
+        .arg_line("--verbose foo")
+        .current_dir(cwd)
+        .assert()
+        .success()
+        .stdout_eq(file!["stdout.term.svg"])
+        .stderr_eq("");
+
+    assert_ui().subset_matches(current_dir!().join("out"), &project_root);
+}