WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Delay feedback / duration changes don't "stick" #768

@okyeron

Description

@okyeron

When in MASH mode, if you change Delay parameters for feedback / duration, those changes will not stay active the next time you enable delay.

It feels like randomization might be happening (even tho the randomizations are set to zero), or its reverting to a default?

is this chunk applicable?

if (sf->fx_active[FX_DELAY] && sf->fx_param[FX_DELAY][2] > 30) {

or... is it problematic that one of these is Delay *self and the other is Delay *tapeDelay?

void Delay_setFeedbackf(Delay *self, float feedback) {
  self->feedback = feedback;
  self->feedback_fp = q16_16_float_to_fp(self->feedback);
}
void Delay_setDuration(Delay *tapeDelay, float delay_time) {
  tapeDelay->delay_time = delay_time;
}

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions