[MRG]Fix compatibility with scikit-learn 1.8+ #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scikit-learn 1.8.0+ removed the algorithm parameter from AdaBoostClassifier scikit-learn/scikit-learn#32262 The changes maintain compatibility with previous version of scikit-learn
stratakis
changed the title
In scikit-learn 1.8, the _check_targets() function signature changed to accept and return sample_weight as an extra value. See: scikit-learn/scikit-learn#31701 This commit adds version checking to handle both APIs. This maintains backward compatibility with scikit-learn < 1.8.
stratakis
force-pushed
the
scikit-learn-1.8.0
branch
from
30df912 to
2685b68
Compare
stratakis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scikit-learn 1.8.0+ removed the algorithm parameter from AdaBoostClassifier and changed the function signature of _check_targets().
scikit-learn/scikit-learn#32262
scikit-learn/scikit-learn#31701
The changes maintain compatibility with previous version of scikit-learn
What does this implement/fix? Explain your changes.
This fixes compatibility with scikit-learn 1.8.0+
Any other comments?
Tested on Fedora with scikit-learn 1.8.0rc1 as well as 1.7.2 and Python 3.14. All tests passed.