User configure webhookService.type not being respect for helm chart

[zyue110026]

We have noticed an instance of incorrect helming in one of your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from aquasecurity/trivy-operator#729 regarding the incorrect helming defect.

webhookService.type does not take effect when changed to a value other than default value 'ClusterIP'. This is due to webhookService.type is hardcoded in service-webhook-server.yaml file:

kube-fledged/deploy/kubefledged-operator/helm-charts/kubefledged/templates/service-webhook-server.yaml

Line 17 in 837f2b3

type: ClusterIP

Expected Behavior

Change webhookService.type to other type other than 'ClusterIP' can take effect, or remove webhookService.type in values.yaml