WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit 88311af

Browse files
committed
Add jruby-head and disable allow-failure
In order to help ensure JRuby does not break mustermann again, remove the allow-failure flag and add jruby-head with sinatra head for more coverage. The issue reported in jruby/jruby#8920 wouldn't have been released if it had been caught by jruby-head testing in mustermann, and having allow-failure means bugs introduced by JRuby may never be caught by mustermann CI. I will push additional fixes to get the remaining failure green.
1 parent 2e24678 commit 88311af

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ jobs:
2929
- { ruby: 2.6, sinatra: ~> 3.0.0 }
3030
- { ruby: 3.4, sinatra: head }
3131
- { ruby: head, sinatra: head }
32-
# https://github.com/sinatra/mustermann/issues/72
33-
- { ruby: jruby, sinatra: ~> 4.0.0, allow-failure: true }
32+
- { ruby: jruby, sinatra: ~> 4.0.0 }
33+
- { ruby: jruby-head, sinatra: head }
3434
# https://github.com/sinatra/mustermann/issues/143
3535
- { ruby: truffleruby, sinatra: ~> 4.0.0, allow-failure: true }
3636
env:

0 commit comments

Comments
 (0)