WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Throw correct exception for very large port numbers #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
philip-healy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Throw correct exception for very large port numbers #77

philip-healy wants to merge 1 commit into from

Conversation

@philip-healy
Copy link

@philip-healy philip-healy commented Apr 24, 2020

Throw GalimatiasParseException instead of NumberFormatException when port number > Integer.MAX_VALUE

@coveralls
Copy link

coveralls commented Apr 24, 2020

Coverage Status

Coverage increased (+0.02%) to 87.608% when pulling a9cb858 on philip-healy:port-number-parsing-fix into 35b54cc on smola:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philip-healy @coveralls