WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Commit 1893f89

Browse files
ayeteadoeADKaster
authored andcommitted
Meta: Update Windows Nightly CI to Windows 2025 Image with Sanitizers
Github Actions just updated windows-2025 to LLVM 20, which is the minimum version required for us to build and run tests with sanitizers Now that we've added support, enable the Sanitizer build in CI.
1 parent d9d6e55 commit 1893f89

File tree

1 file changed

+21
-7
lines changed

1 file changed

+21
-7
lines changed

.github/workflows/nightly-windows.yml

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
CI:
2020
if: github.repository == 'LadybirdBrowser/ladybird'
2121

22-
runs-on: windows-2022
22+
runs-on: windows-2025
2323

2424
steps:
2525
- uses: actions/checkout@v4
@@ -41,34 +41,48 @@ jobs:
4141
uses: ./.github/actions/cache-restore
4242
id: 'cache-restore'
4343
with:
44-
runner_labels: '["windows-2022"]'
44+
runner_labels: '["windows-2025"]'
4545
os: Windows
4646
arch: x86_64
4747
toolchain: ClangCL
48-
cache_key_extra: Windows_CI
48+
cache_key_extra: Windows_Sanitizer_CI
4949
download_cache_path: ${{ github.workspace }}/Build/caches
5050
vcpkg_cache_path: ${{ github.workspace }}/Build/caches/vcpkg-binary-cache
5151

5252
- name: Create Build Environment
5353
working-directory: ${{ github.workspace }}
5454
run: |
55-
cmake --preset Windows_CI
55+
cmake --preset Windows_Sanitizer_CI
5656
5757
- name: Build
5858
working-directory: ${{ github.workspace }}
5959
run: |
60-
cmake --build --preset Windows_CI
60+
cmake --build --preset Windows_Sanitizer_CI
6161
6262
- name: Save Caches
6363
uses: ./.github/actions/cache-save
6464
with:
65-
runner_labels: '["windows-2022"]'
65+
runner_labels: '["windows-2025"]'
6666
arch: x86_64
6767
vcpkg_cache_path: ${{ github.workspace }}/Build/caches/vcpkg-binary-cache
6868
vcpkg_cache_primary_key: ${{ steps.cache-restore.outputs.vcpkg_cache_primary_key }}
6969

7070
- name: Test
7171
working-directory: ${{ github.workspace }}
72-
run: ctest --preset Windows_CI --timeout 1800
72+
run: ctest --preset Windows_Sanitizer_CI --timeout 1800
7373
env:
7474
TESTS_ONLY: 1
75+
ASAN_OPTIONS: 'log_path="${{ github.workspace }}\asan.log"'
76+
UBSAN_OPTIONS: 'log_path="${{ github.workspace }}\ubsan.log"'
77+
78+
- name: Sanitizer Output
79+
if: ${{ !cancelled() && inputs.build_preset == 'Windows_Sanitizer_CI' }}
80+
working-directory: ${{ github.workspace }}
81+
run: |
82+
log_output=$(find . -maxdepth 1 \( -name 'asan.log.*' -o -name 'ubsan.log.*' \) -exec cat {} \; )
83+
if [ -z "$log_output" ]; then
84+
echo "No sanitizer issues found."
85+
else
86+
echo "$log_output"
87+
echo "Sanitizer errors happened while running tests; see the Test step above."
88+
fi

0 commit comments

Comments
 (0)