[JSC] Don't get RegExp well-known symbol methods for primitives

https://bugs.webkit.org/show_bug.cgi?id=290684

Reviewed by Yusuke Suzuki.

This patch implements tc39/ecma262#3009.
test262 has been updated for it already[1].

[1]: tc39/test262@abc22b5

* JSTests/test262/expectations.yaml:
* Source/JavaScriptCore/builtins/StringPrototype.js:
(match):
(matchAll):
(intrinsic.StringPrototypeReplaceIntrinsic.replace):
(intrinsic.StringPrototypeReplaceAllIntrinsic.replaceAll):
(search):
(split):

Canonical link: https://commits.webkit.org/292913@main

Author: sosukesuzuki

JSTests/microbenchmarks/string-prototype-search-observable-side-effects2.js

@@ -21,8 +21,8 @@ function assert(testedValue, msg) {
 
     assert(accesses == "", "unexpected call to overridden props");
     let result = "searchme".search(obj);
-    assert(accesses == "Symbol(Symbol.search)", "Property accesses do not match expectation");
-    assert(result === 3, "Unexpected result");
+    assert(accesses == "", "unexpected call to overridden props");
+    assert(result === 0, "Unexpected result");
 
     Object.defineProperty(String.prototype, Symbol.search, { value: undefined, writable: false, configurable: true });
 })();

JSTests/microbenchmarks/string-prototype-search-observable-side-effects3.js

@@ -21,8 +21,8 @@ function assert(testedValue, msg) {
 
     assert(accesses == "", "unexpected call to overridden props");
     let result = "searchme".search(obj);
-    assert(accesses == "Symbol(Symbol.search)", "Property accesses do not match expectation");
-    assert(result === 3, "Unexpected result");
+    assert(accesses == "", "unexpected call to overridden props");
+    assert(result === 0, "Unexpected result");
 
     Object.defineProperty(String.prototype, Symbol.search, { value: undefined, writable: false, configurable: true });
 })();

JSTests/stress/string-replace-deopt-object.js

@@ -3,14 +3,17 @@ function shouldBe(actual, expected) {
         throw new Error('bad value: ' + actual);
 }
 
-function test(string) {
-    return string.replace("Hello", "World");
+function test(string, pattern, replacement) {
+    return string.replace(pattern, replacement);
 }
 noInline(test);
 
 for (var i = 0; i < testLoopCount; ++i)
-    shouldBe(test("Hello"), "World");
+    shouldBe(test("Hello", "Hello", "World"), "World");
 
 Object.prototype[Symbol.replace] = function () { return "Changed"; };
 for (var i = 0; i < testLoopCount; ++i)
-    shouldBe(test("Hello"), "Changed");
+    shouldBe(test("Hello", "Hello", "World"), "World");
+
+for (var i = 0; i < testLoopCount; ++i)
+    shouldBe(test("Hello", {}, "World"), "Changed");

JSTests/stress/string-replace-deopt.js

@@ -13,4 +13,4 @@ for (var i = 0; i < testLoopCount; ++i)
 
 String.prototype[Symbol.replace] = function () { return "Changed"; };
 for (var i = 0; i < testLoopCount; ++i)
-    shouldBe(test("Hello"), "Changed");
+    shouldBe(test("Hello"), "World");

JSTests/test262/expectations.yaml

@@ -67,75 +67,6 @@ test/built-ins/Proxy/construct/return-not-object-throws-undefined-realm.js:
 test/built-ins/Proxy/construct/trap-is-not-callable-realm.js:
   default: 'Test262Error: Expected a TypeError but got a different error constructor with the same name'
   strict mode: 'Test262Error: Expected a TypeError but got a different error constructor with the same name'
-test/built-ins/String/prototype/match/cstm-matcher-on-bigint-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/match/cstm-matcher-on-boolean-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/match/cstm-matcher-on-number-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/match/cstm-matcher-on-string-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/matchAll/cstm-matchall-on-bigint-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/matchAll/cstm-matchall-on-number-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/matchAll/cstm-matchall-on-string-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/replace/cstm-replace-on-bigint-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/replace/cstm-replace-on-boolean-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/replace/cstm-replace-on-number-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/replace/cstm-replace-on-string-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/replaceAll/cstm-replaceall-on-bigint-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/replaceAll/cstm-replaceall-on-boolean-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/replaceAll/cstm-replaceall-on-number-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/replaceAll/cstm-replaceall-on-string-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/search/cstm-search-on-bigint-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/search/cstm-search-on-boolean-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/search/cstm-search-on-number-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/search/cstm-search-on-string-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/split/cstm-split-on-bigint-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/split/cstm-split-on-boolean-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/split/cstm-split-on-number-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
-test/built-ins/String/prototype/split/cstm-split-on-string-primitive.js:
-  default: 'Test262Error: should not be called'
-  strict mode: 'Test262Error: should not be called'
 test/built-ins/Temporal/Duration/compare/compare-no-precision-loss.js:
   default: 'Test262Error: Expected SameValue(«0», «0») to be false'
   strict mode: 'Test262Error: Expected SameValue(«0», «0») to be false'

Source/JavaScriptCore/builtins/StringPrototype.js

@@ -32,7 +32,7 @@ function match(regexp)
     if (@isUndefinedOrNull(this))
         @throwTypeError("String.prototype.match requires that |this| not be null or undefined");
 
-    if (!@isUndefinedOrNull(regexp)) {
+    if (@isObject(regexp)) {
         var matcher = regexp.@@match;
         if (!@isUndefinedOrNull(matcher))
             return matcher.@call(regexp, this);
@@ -50,7 +50,7 @@ function matchAll(arg)
     if (@isUndefinedOrNull(this))
         @throwTypeError("String.prototype.matchAll requires |this| not to be null nor undefined");
 
-    if (!@isUndefinedOrNull(arg)) {
+    if (@isObject(arg)) {
         if (@isRegExp(arg) && !@stringIncludesInternal.@call(@toString(arg.flags), "g"))
             @throwTypeError("String.prototype.matchAll argument must not be a non-global regular expression");
 
@@ -267,7 +267,7 @@ function replace(search, replace)
     if (@isUndefinedOrNull(this))
         @throwTypeError("String.prototype.replace requires that |this| not be null or undefined");
 
-    if (!@isUndefinedOrNull(search)) {
+    if (@isObject(search)) {
         var replacer = search.@@replace;
         if (!@isUndefinedOrNull(replacer)) {
             if (!@hasObservableSideEffectsForStringReplace(search, replacer))
@@ -289,7 +289,7 @@ function replaceAll(search, replace)
     if (@isUndefinedOrNull(this))
         @throwTypeError("String.prototype.replaceAll requires |this| not to be null nor undefined");
 
-    if (!@isUndefinedOrNull(search)) {
+    if (@isObject(search)) {
         if (@isRegExp(search) && !@stringIncludesInternal.@call(@toString(search.flags), "g"))
             @throwTypeError("String.prototype.replaceAll argument must not be a non-global regular expression");
 
@@ -313,7 +313,7 @@ function search(regexp)
     if (@isUndefinedOrNull(this))
         @throwTypeError("String.prototype.search requires that |this| not be null or undefined");
 
-    if (!@isUndefinedOrNull(regexp)) {
+    if (@isObject(regexp)) {
         var searcher = regexp.@@search;
         if (!@isUndefinedOrNull(searcher))
             return searcher.@call(regexp, this);
@@ -331,7 +331,7 @@ function split(separator, limit)
     if (@isUndefinedOrNull(this))
         @throwTypeError("String.prototype.split requires that |this| not be null or undefined");
 
-    if (!@isUndefinedOrNull(separator)) {
+    if (@isObject(separator)) {
         var splitter = separator.@@split;
         if (!@isUndefinedOrNull(splitter))
             return splitter.@call(separator, this, limit);