GetLastError() doesn't return anything if the call succeeds

AZero13 · AZero13 · commit 9aad7cc0a9da · 2025-12-11T10:48:41.000-05:00
diff --git a/Sources/FoundationEssentials/FileManager/FileOperations.swift b/Sources/FoundationEssentials/FileManager/FileOperations.swift
@@ -618,7 +618,7 @@ enum _FileOperations {
                     try destination.withNTPathRepresentation { pwszDestination in
                         var faDestinationAttributes: WIN32_FILE_ATTRIBUTE_DATA = .init()
                         if GetFileAttributesExW(pwszDestination, GetFileExInfoStandard, &faDestinationAttributes) {
-                            let error = CocoaError.moveFileError(GetLastError(), src, dst)
+                            let error = CocoaError.moveFileError(ERROR_ALREADY_EXISTS, src, dst)
                             guard fileManager._shouldProceedAfter(error: error, movingItemAtPath: source, to: destination) else {
                                 throw error
                             }

Original file line number	Diff line number	Diff line change
`@@ -618,7 +618,7 @@ enum _FileOperations {`
`618`	`618`	`try destination.withNTPathRepresentation { pwszDestination in`
`619`	`619`	`var faDestinationAttributes: WIN32_FILE_ATTRIBUTE_DATA = .init()`
`620`	`620`	`if GetFileAttributesExW(pwszDestination, GetFileExInfoStandard, &faDestinationAttributes) {`
`621`		`- let error = CocoaError.moveFileError(GetLastError(), src, dst)`
	`621`	`+ let error = CocoaError.moveFileError(ERROR_ALREADY_EXISTS, src, dst)`
`622`	`622`	`guard fileManager._shouldProceedAfter(error: error, movingItemAtPath: source, to: destination) else {`
`623`	`623`	`throw error`
`624`	`624`	`}`