fix: fixes runtime permissions

Fixes #397

Author: abs51295

app/src/main/java/com/peacecorps/pcsa/MainActivity.java

@@ -1,16 +1,25 @@
 package com.peacecorps.pcsa;
 
+import android.Manifest;
+import android.content.DialogInterface;
 import android.content.Intent;
 import android.content.IntentFilter;
 import android.content.SharedPreferences;
+import android.content.pm.PackageManager;
+import android.net.Uri;
+import android.os.Build;
 import android.os.Bundle;
 import android.preference.PreferenceManager;
+import android.provider.Settings;
+import android.support.annotation.NonNull;
+import android.support.annotation.RequiresApi;
 import android.support.v4.app.Fragment;
 import android.support.v4.app.FragmentActivity;
 import android.support.v4.app.FragmentManager;
 import android.support.v4.view.GravityCompat;
 import android.support.v4.widget.DrawerLayout;
 import android.support.v7.app.ActionBarDrawerToggle;
+import android.support.v7.app.AlertDialog;
 import android.support.v7.app.AppCompatActivity;
 import android.support.v7.widget.Toolbar;
 import android.util.Log;
@@ -40,7 +49,6 @@
 import com.peacecorps.pcsa.support_services.ConfidentialityFragment;
 import com.peacecorps.pcsa.support_services.MythbustersFragment;
 
-import java.lang.reflect.Array;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.HashMap;
@@ -50,44 +58,77 @@
 
 public class MainActivity extends AppCompatActivity {
 
+    private static final String TAG = MainActivity.class.getSimpleName();
+    private static final int PERMISSION_CALLBACK = 100;
+    private static final int PERMISSION_SETTINGS = 101;
+    public static boolean refreshList = false;
+    public static String FRAGMENT_TAG = MainActivityFragment.TAG;
+    SharedPreferences sharedPreferences;
     private Toolbar toolbar;
     private DrawerLayout mDrawer;
     private NavDrawerListAdapter listAdapter;
     private ExpandableListView expListView;
     private List<String> listDataHeader;
-    public static boolean refreshList= false;
     private HashMap<String, List<String>> listDataChild;
-    private static final String TAG = MainActivity.class.getSimpleName();
-    public static String FRAGMENT_TAG = MainActivityFragment.TAG;
     private FragmentManager fragmentManager = getSupportFragmentManager();
-    SharedPreferences sharedPreferences;
-    private int lastExpandedGroup=-1;
+    private int lastExpandedGroup = -1;
     private int lastChildExpandedGroup = -1;
+    private String[] runTimePermissions = new String[]{Manifest.permission.ACCESS_FINE_LOCATION, Manifest.permission.SEND_SMS, Manifest.permission.CALL_PHONE, Manifest.permission.READ_CONTACTS};
+
+    public static void swapFragmentIn(FragmentActivity activity, Fragment fragment, String TAG, boolean addToBackStack) {
+        FragmentManager fragmentManager = activity.getSupportFragmentManager();
+        // Insert the fragment by replacing any existing fragment
+        FRAGMENT_TAG = TAG;
+        int animEnter = R.anim.push_down_in;
+        int animExit = R.anim.push_down_out;
+        int animPopEnter = R.anim.fade_in;
+        int animPopExit = R.anim.fade_out;
+
+        if (addToBackStack) {
+            if (TAG.equals(ContactOtherStaff.TAG)) {
+                animEnter = R.anim.fade_in;
+                animExit = R.anim.fade_out;
+                animPopEnter = R.anim.fade_in_back;
+                animPopExit = R.anim.fade_out_back;
+            }
+            fragmentManager.beginTransaction()
+                    .setCustomAnimations(animEnter, animExit, animPopEnter, animPopExit)
+                    .replace(R.id.fragment_container
+                            , fragment, TAG)
+                    .addToBackStack(TAG)
+                    .commit();
+        } else {
+            animEnter = R.anim.fade_in;
+            animExit = R.anim.fade_out;
+            fragmentManager.beginTransaction()
+                    .setCustomAnimations(animEnter, animExit, animPopEnter, animPopExit)
+                    .replace(R.id.fragment_container
+                            , fragment, TAG)
+                    .commit();
+        }
+    }
 
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         setContentView(R.layout.activity_main);
-        if(savedInstanceState != null)
-        {
+        if (savedInstanceState != null) {
             /*
             * Check if instance of the required fragment is available
             * in the backstack and swap it into the container
             */
             Fragment unknownFragment = fragmentManager.findFragmentByTag(FRAGMENT_TAG);
-            if(unknownFragment != null){
-                MainActivity.swapFragmentIn(this,unknownFragment,FRAGMENT_TAG,false);
+            if (unknownFragment != null) {
+                MainActivity.swapFragmentIn(this, unknownFragment, FRAGMENT_TAG, false);
             }
-        }
-        else
-        {
+        } else {
             Fragment mainActivityFragment = new MainActivityFragment();
-            swapFragmentIn(this,mainActivityFragment,MainActivityFragment.TAG,false);
+            swapFragmentIn(this, mainActivityFragment, MainActivityFragment.TAG, false);
         }
         sharedPreferences = PreferenceManager.getDefaultSharedPreferences(this);
-        toolbar = (Toolbar)findViewById(R.id.toolbar);
+        toolbar = (Toolbar) findViewById(R.id.toolbar);
         setSupportActionBar(toolbar);
-        mDrawer = (DrawerLayout)findViewById(R.id.drawer_layout);
+        mDrawer = (DrawerLayout) findViewById(R.id.drawer_layout);
         ActionBarDrawerToggle toggle = new ActionBarDrawerToggle(
                 this, mDrawer, toolbar, R.string.navigation_drawer_open, R.string.navigation_drawer_close);
         mDrawer.setDrawerListener(toggle);
@@ -261,50 +302,16 @@ public boolean onChildClick(ExpandableListView parent, View v, int groupPosition
         });
     }
 
-    public static void swapFragmentIn(FragmentActivity activity, Fragment fragment, String TAG, boolean addToBackStack)
-    {
-        FragmentManager fragmentManager = activity.getSupportFragmentManager();
-        // Insert the fragment by replacing any existing fragment
-        FRAGMENT_TAG = TAG;
-        int animEnter = R.anim.push_down_in;
-        int animExit = R.anim.push_down_out;
-        int animPopEnter = R.anim.fade_in;
-        int animPopExit = R.anim.fade_out;
-
-        if(addToBackStack){
-            if (TAG.equals(ContactOtherStaff.TAG)) {
-                animEnter = R.anim.fade_in;
-                animExit = R.anim.fade_out;
-                animPopEnter = R.anim.fade_in_back;
-                animPopExit = R.anim.fade_out_back;
-            }
-            fragmentManager.beginTransaction()
-                    .setCustomAnimations(animEnter, animExit, animPopEnter, animPopExit)
-                    .replace(R.id.fragment_container
-                            , fragment,TAG)
-                    .addToBackStack(TAG)
-                    .commit();
-        } else {
-            animEnter = R.anim.fade_in;
-            animExit = R.anim.fade_out;
-            fragmentManager.beginTransaction()
-                    .setCustomAnimations(animEnter, animExit, animPopEnter, animPopExit)
-                    .replace(R.id.fragment_container
-                            , fragment,TAG)
-                    .commit();
-        }
-    }
-
     /**
      * Populating the expandable list of the Navigation Drawer
      */
     private void prepareListData() {
 
         listDataChild = new HashMap<String, List<String>>();
         listDataHeader = new LinkedList<>(Arrays.asList(getResources().getStringArray(R.array.headers)));
-        String userName = sharedPreferences.getString(getString(R.string.key_name),"");
-        String lastElement = listDataHeader.get(listDataHeader.size()-1) + " " + userName.trim();
-        listDataHeader.remove(listDataHeader.size()-1);
+        String userName = sharedPreferences.getString(getString(R.string.key_name), "");
+        String lastElement = listDataHeader.get(listDataHeader.size() - 1) + " " + userName.trim();
+        listDataHeader.remove(listDataHeader.size() - 1);
         listDataHeader.add(lastElement);
 
         List<String> getHelpNow = new ArrayList<>();
@@ -339,20 +346,19 @@ public void onBackPressed() {
     @Override
     protected void onPause() {
         super.onPause();
-        overridePendingTransition(R.anim.fade_in,R.anim.fade_out);
-        try{
+        overridePendingTransition(R.anim.fade_in, R.anim.fade_out);
+        try {
             unregisterReceiver(CircleOfTrustFragment.sentReceiver);
-        }catch (IllegalArgumentException e){
-            Log.e(TAG,"Not registered");
+        } catch (IllegalArgumentException e) {
+            Log.e(TAG, "Not registered");
         }
     }
 
     @Override
     protected void onResume() {
         super.onResume();
         registerReceiver(CircleOfTrustFragment.sentReceiver, new IntentFilter(CircleOfTrustFragment.SENT));
-        if(refreshList)
-        {
+        if (refreshList) {
             refreshList = false;
             prepareListData();
             listAdapter = new NavDrawerListAdapter(this, listDataHeader, listDataChild);
@@ -377,4 +383,90 @@ public boolean onOptionsItemSelected(MenuItem item) {
         }
         return true;
     }
+
+    @Override
+    protected void onStart() {
+        super.onStart();
+        if (Build.VERSION.SDK_INT > Build.VERSION_CODES.LOLLIPOP_MR1) {
+            requestRunTimePermissions();
+        }
+    }
+
+    @RequiresApi(23)
+    @Override
+    public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {
+        super.onRequestPermissionsResult(requestCode, permissions, grantResults);
+        if (requestCode == PERMISSION_CALLBACK) {
+            boolean showRationale = false;
+            for (int i = 0, len = permissions.length; i < len; i++) {
+                if (grantResults[i] == PackageManager.PERMISSION_DENIED) {
+                    showRationale = showRationale || shouldShowRequestPermissionRationale(permissions[i]);
+                }
+            }
+            if (showRationale) {
+                requestPermissions(permissions, PERMISSION_CALLBACK);
+            } else if (!areAllRunTimePermissionsGranted(permissions)) {
+                AlertDialog.Builder builder = new AlertDialog.Builder(this);
+                builder.setCancelable(false);
+                builder.setTitle(getString(R.string.permission_dialog_title));
+                builder.setMessage(getString(R.string.permission_dialog_message));
+                builder.setPositiveButton(getString(R.string.permission_dialog_positive_button), new DialogInterface.OnClickListener() {
+                    @Override
+                    public void onClick(DialogInterface dialog, int which) {
+                        dialog.cancel();
+                        Intent intent = new Intent(Settings.ACTION_APPLICATION_DETAILS_SETTINGS);
+                        Uri uri = Uri.fromParts("package", getPackageName(), null);
+                        intent.setData(uri);
+                        startActivityForResult(intent, PERMISSION_SETTINGS);
+                    }
+                });
+                builder.setNegativeButton(getString(R.string.permission_dialog_negative_button), new DialogInterface.OnClickListener() {
+                    @Override
+                    public void onClick(DialogInterface dialog, int which) {
+                        dialog.cancel();
+                        finish();
+                    }
+                });
+                builder.show();
+            }
+        }
+    }
+
+    @Override
+    protected void onActivityResult(int requestCode, int resultCode, Intent data) {
+        super.onActivityResult(requestCode, resultCode, data);
+        if (requestCode == PERMISSION_SETTINGS) {
+            if (Build.VERSION.SDK_INT > Build.VERSION_CODES.LOLLIPOP_MR1) {
+                if (!areAllRunTimePermissionsGranted(runTimePermissions)) {
+                    Toast.makeText(this, getString(R.string.permission_toast), Toast.LENGTH_SHORT).show();
+                    finish();
+                }
+            }
+        }
+    }
+
+    /**
+     * Requests run time permissions.
+     */
+    @RequiresApi(23)
+    private void requestRunTimePermissions() {
+        if (!areAllRunTimePermissionsGranted(runTimePermissions)) {
+            requestPermissions(runTimePermissions, PERMISSION_CALLBACK);
+        }
+    }
+
+    /**
+     * Checks if all the run time permissions are granted.
+     *
+     * @param permissions required permissions.
+     * @return true if all permissions are granted.
+     */
+    @RequiresApi(23)
+    private boolean areAllRunTimePermissionsGranted(String[] permissions) {
+        boolean allPermissionsGranted = true;
+        for (String permission : permissions) {
+            allPermissionsGranted = allPermissionsGranted && checkSelfPermission(permission) == PackageManager.PERMISSION_GRANTED;
+        }
+        return allPermissionsGranted;
+    }
 }

app/src/main/java/com/peacecorps/pcsa/circle_of_trust/LocationHelper.java

@@ -63,6 +63,8 @@ public void onProviderDisabled(String provider) {
                 Log.e(TAG, "Unable to listen to GPS location updates", e);
             } catch (NullPointerException e) {
                 Log.e(TAG, "Unable to get location services", e);
+            } catch (SecurityException e) {
+                Log.e(TAG, "No permission for location", e);
             }
         }
     }
@@ -74,7 +76,11 @@ public void onProviderDisabled(String provider) {
     public void stopAcquiringLocation() {
         if (locationManager != null && locationListener != null) {
             // Remove the listener which added by calling #startAcquiringLocation
-            locationManager.removeUpdates(locationListener);
+            try {
+                locationManager.removeUpdates(locationListener);
+            } catch (SecurityException e) {
+                Log.e(TAG, "No permission for location", e);
+            }
         }
     }
 
@@ -86,7 +92,11 @@ public void stopAcquiringLocation() {
      */
     public Location retrieveLocation(boolean needLastKnown) {
         if (lastLocation == null && locationManager != null && needLastKnown) {
-            lastLocation = locationManager.getLastKnownLocation(LOCATION_PROVIDER);
+            try {
+                lastLocation = locationManager.getLastKnownLocation(LOCATION_PROVIDER);
+            } catch (SecurityException e) {
+                Log.e(TAG, "No permission for location", e);
+            }
         }
         return lastLocation;
     }

app/src/main/res/values/strings.xml

@@ -4,6 +4,11 @@
     <!--Common-->
     <string name="dialog_call">Voice Call</string>
     <string name="dialog_message">Send Message</string>
+    <string name="permission_dialog_negative_button">Close App</string>
+    <string name="permission_dialog_message">This Application Needs Multiple Permissions in order to work correctly.</string>
+    <string name="permission_dialog_positive_button">Open Settings</string>
+    <string name="permission_dialog_title">Need Permissions</string>
+    <string name="permission_toast">Permissions Not Granted</string>
 
     <!--Activity Titles-->
     <string name="title_activity_faq">Frequently Asked Questions</string>