WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Reword template based provisioning #4295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maximiliankolb wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reword template based provisioning #4295

maximiliankolb wants to merge 2 commits into from

Conversation

@maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb commented Sep 24, 2025

What changes are you introducing?

  • Reword introduction to adding VMware/Proxmox images to Foreman to perform image-based host provisioning
  • Splitt WebUI/CLI procedure for VMware similar to Proxmox

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Fixes #4288

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Tested Hammer CLI commands for VMware and Proxmox on Foreman 3.14 ✔️

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Sep 24, 2025
@github-actions
Copy link

github-actions bot commented Sep 24, 2025

The PR preview for fa906af is available at theforeman-foreman-documentation-preview-pr-4295.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

Lennonka
Lennonka requested changes Oct 2, 2025
View reviewed changes
guides/common/modules/proc_adding-proxmox-images-to-project-by-using-cli.adoc

Proxmox uses templates as images for creating virtual machines.
When you use image-based provisioning to create new hosts, add Proxmox template details to your {Project}.
Add Proxmox images to {Project} to perform image-based host provisioning on Proxmox.
Copy link
Contributor

@Lennonka Lennonka Oct 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I struggled to remember why this wording was so strange (in VMware).

The problem is this: what we call "images" in Foreman are called "templates" in VMware. I don't know what they call them in Proxmox. I started calling them "image templates" in provisioning methods.

Now I hesitate to change it because it would be good for users' understanding to create a connection between those two terminologies. Could you try to consider an alternative wording?

This applies to all modules in this PR.

Copy link
Contributor Author

@maximiliankolb maximiliankolb Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can drop 9c3aaf4 from the PR and only add the CLI procecures for now. Or is this something I should bring up in the provisioning interest group? cc @goarsna

Or maybe we need to extend our glossary/provisioning overview?

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Oct 2, 2025
@maximiliankolb
Copy link
Contributor Author

maximiliankolb commented Nov 13, 2025

triage: rethink terminology again; possible make it italic or extend the glossary

link to official vmware/proxmox docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lennonka Lennonka Lennonka requested changes

Assignees

No one assigned

Labels

Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing Waiting on contributor Requires an action from the author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reword introduction to adding VMware/Proxmox images to Foreman

2 participants

@maximiliankolb @Lennonka