Fixes #38742 - Add fixed IP address support for OpenStack

[nofaralfasi]

No description provided.

[Loumy]

Hello,
doesn't work for me : Path applied on foreman-openstack-3.16.0-1.el9.noarch
I add a logger here a363023#diff-87c1d0cf83bae98b382f8bffe3d2e4542d688420c88641bc482ef370f297e02aR168
and the value is : [{"net_id"=>"9cd70c0c-c8d0-4b13-8643-a40a2f0563c5"}]
The value of interface was : {"0"=>{"ip"=>"172.22.1.50", "ip6"=>""}}

[nofaralfasi]

Hello, doesn't work for me

Thanks for sharing! I’ll take a look and work on fixing it.

[nofaralfasi]

Hi @Loumy, could you give it another round of testing?

[Loumy]

Thanks @nofaralfasi but still not working.

2025-10-01T07:27:28 [W|app|9f130a36] value nics : [{"net_id"=>"9cd70c0c-c8d0-4b13-8643-a40a2f0563c5"}]
2025-10-01T07:27:28 [W|app|9f130a36] value interface: {"0"=>{"ip"=>"172.22.1.50", "ip6"=>""}}
2025-10-01T07:27:28 [W|app|9f130a36] value nics after process: [{"net_id"=>"9cd70c0c-c8d0-4b13-8643-a40a2f0563c5", "fixed_ip"=>"172.22.1.50"}]

But on the json sent to Openstack, I have only the network ID :

{    
  "server": {
    "flavorRef": "1",
    "name": "jaime-goodrick.novalocal",
    "imageRef": "f8fe0725-8155-46ba-86fc-3d22bdcc1a62",
    "metadata": {},                                                                                                                                                                                                    "availability_zone": "nova",                                                                                                                                                                                       "user_data": "[...]"
    "key_name": "foreman-2013a8523-6359-4b92-818f-7ad6c181533d",
    "security_groups": [
      {
        "name": "default"
      }
    ],
    "networks": [
      {
        "uuid": "9cd70c0c-c8d0-4b13-8643-a40a2f0563c5"
      }
    ]
  }
}

[Loumy]

I tried to reproduce with FOG and it works with this

class OpenStackVMManager
  def initialize(auth_params)
    @compute = Fog::Compute.new(auth_params.merge(provider: 'OpenStack'))
    @network = Fog::Network.new(auth_params.merge(provider: 'OpenStack'))
  end

  def create_vm_with_ip(name, image_id, flavor_id, network_id, ip_address)
    begin
      # check if already used IP
      existing_ports = @network.ports.all(fixed_ips: "ip_address=#{ip_address}")
      if existing_ports.any?
        raise "IP #{ip_address} already used"
      end

      # createport
      port = @network.ports.create(
        name: "#{name}-port",
        network_id: network_id,
        fixed_ips: [{ ip_address: ip_address }]
      )

      # Créer la VM
      server = @compute.servers.create(
        name: name,
        image_ref: image_id,
        flavor_ref: flavor_id,
        nics: [{ port_id: port.id }]
      )
[...]

I hope it help, I'm not so skilled in ruby to propose a path, I may try with an AI
fog-openstack (1.1.5)
ruby 3.0.7p220 (2024-04-23 revision 724a071175) [x86_64-linux]

[Loumy]

I made it work finally @nofaralfasi , from [1] the param is supposed v4_fixed_ip here [2] and not fixed_ip
[1] https://github.com/fog/fog-openstack/blob/master/lib/fog/openstack/compute/requests/create_server.rb#L50C42-L50C53
[2]

foreman/app/models/compute_resources/foreman/model/openstack.rb

Line 361 in 47bf84d

nic['fixed_ip'] = ip

[nofaralfasi]

Hi @Loumy, thanks for your review and comments. I was on PTO but will go through your feedback and update the PR ASAP.

[nofaralfasi]

Hi @Loumy,

Two things:

1. Could you please confirm that my latest update (based on your most recent comment) works as expected?
2. Regarding your comment here - I just want to confirm that the additional code you mentioned isn’t needed anymore, and that my recent changes resolve the issue on their own. If that’s not the case, could you share a bit more context about the code you added?

Thanks!

[clopnis]

@nofaralfasi I tested it on version 3.16.0 and it works like a charm great jobs.

2. it was just a reproducer to test if was on FOG or not and not, you can forget this snippet

Many thanks !

[nofaralfasi]

Thanks a lot @clopnis! 😊
Glad to hear it’s working well.
And thanks for clarifying about the snippet - I’ll leave it out then.

[stejskalleos]

Suggested change

	process_fixed_ips(args) if args[:interfaces_attributes].present?
	process_fixed_ips(args)

There is another return unless interfaces_attrs&.any? check in the method itself

[stejskalleos]

How about IPv6?

[stejskalleos]

This could be filtered out at the begining of the method so we can skip the ordering and everything:

nics = args[:nics].reject_if ....
return if nics.empty?

[stejskalleos]

Can you skip the sorting and just call interfaces_attrs[index.to_s] later on?

[clopnis]

tested and works on 3.16 with Openstack Epoxy

[stejskalleos]

Thanks @nofaralfasi @clopnis