Fixes #38759 - Improve upgrade rake task error message #10694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to "foreman-rake upgrade:run" rake task.
quba42
commented
Sep 18, 2025
| Rake::Task[task.task_name].execute | ||
| rescue => e | ||
| puts "Failed upgrade task: #{task.name}, see logs for more information." | ||
| puts "Failed upgrade task: #{task.name}, see '/var/log/foreman/production.log' for more information." |
Contributor
Author
There was a problem hiding this comment.
Is it possible to check where logging is going at run time, so we can make this part of the message contingent on what kind of logging is configured on the current foreman instance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to "foreman-rake upgrade:run" rake task.
Problem:
foreman-installer, this happens with every foreman-installer run.foreman-installervery visibly tells users, for example: "The full log is at /var/log/foreman-installer/katello.log".=> Users are not directed to the foreman production log, and will end up chasing ghosts.
Ideally we can point users equally explicitly to a specific place like
/var/log/foreman/production.logas well, however this is only correct if file based logging is configured on the foreman instance.So my question is: Is it possible to know the logging configuration from the rake task run, and make the message conditional on that?