Generate certificate bundle #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
force-pushed
the
generate-certificate-bundle
branch
4 times, most recently
from
b6c101f to
dc3b348
Compare
ehelms
force-pushed
the
generate-certificate-bundle
branch
from
dc3b348 to
b84f5e7
Compare
ehelms
force-pushed
the
generate-certificate-bundle
branch
from
b84f5e7 to
d79a072
Compare
ehelms
force-pushed
the
generate-certificate-bundle
branch
from
d79a072 to
896243b
Compare
Member
Author
|
@evgeni do you think we should merge this in to have this functionality available? |
Member
|
This is sort-of, but not exactly, foreman-proxy-certs-generate? |
Member
Author
|
Yes - this only generates the bundle, it does not generate a set of certificates to be used. |
Member
Author
I don't know why I said that. It does generate: |
Signed-off-by: Eric D. Helms <[email protected]>
evgeni
force-pushed
the
generate-certificate-bundle
branch
from
896243b to
a9ad699
Compare
evgeni
reviewed
Nov 24, 2025
evgeni
reviewed
Nov 24, 2025
Comment on lines
+15
to
+16
| - role: foreman_installer_certs | ||
| when: "certificate_source == 'installer'" |
Member
There was a problem hiding this comment.
This won't work as that role is not present on a prod install. How do we want to handle that?
evgeni
force-pushed
the
generate-certificate-bundle
branch
from
a9ad699 to
05a6c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an idea I am playing around with. To help with splitting the installation, this would allow new installer method to generate a certificate tarball the same structure as expected input as what's created today.
This includes #89