Use common String utilities #11839
Open
Use common String utilities #11839
+1,437
−716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
SaloniKasbekar,
Zclarkwilliams,
ajfish,
ardbiesheuvel,
changab,
dandanbi,
jkolakow,
jyao1,
kraxel,
leiflindholm,
lgao4,
makubacki,
mdkinney,
mikebeaton and
os-d
pierregondois
force-pushed
the
pg/string_cleanup
branch
from
578817d to
d06b1f6
Compare
Add the following functions to BaseLib: - StrCharIsLowerAlpha () - StrCharIsUpperAlpha () - StrCharIsAlpha () - StrCharIsNum () - StrCharIsHexNum () - StrCharIsUpperHexNum () - StrCharIsAlphaNum () - StrnIsLowerAlpha () - StrnIsUpperAlpha () - StrnIsAlpha () - StrnIsNum () - StrnIsHexNum () - StrnIsUpperHexNum () - StrnIsAlphaNum () Signed-off-by: Pierre Gondois <[email protected]>
Replace hard-coded string checks by the new utility functions added to BaseLib. Signed-off-by: Pierre Gondois <[email protected]>
Replace hard-coded string checks by the new utility functions added to BaseLib. Signed-off-by: Pierre Gondois <[email protected]>
Replace hard-coded string checks by the new utility functions added to BaseLib. Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace VarCheckInternalIsHexaDecimalDigitCharacter() by StrCharIsUpperHexNum(). Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace InternalIsDecimalDigitCharacter() by StrCharIsNum(). Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace InternalIsHexaDecimalDigitCharacter() by StrCharIsHexNum(). Signed-off-by: Pierre Gondois <[email protected]>
Replace hard-coded string checks by the new utility functions added to BaseLib. Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace IsNumberLetterOnly() by StrnIsAlphaNum(). Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace ShellIsHexaDecimalDigitCharacter() by StrCharIsHexNum(). Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace ShellIsDecimalDigitCharacter() by StrCharIsNum(). Signed-off-by: Pierre Gondois <[email protected]>
Add the following functions to BaseLib: - AsciiCharIsLowerAlpha () - AsciiCharIsUpperAlpha () - AsciiCharIsAlpha () - AsciiCharIsNum () - AsciiCharIsHexNum () - AsciiCharIsUpperHexNum () - AsciiCharIsAlphaNum () - AsciiStrnIsLowerAlpha () - AsciiStrnIsUpperAlpha () - AsciiStrnIsAlpha () - AsciiStrnIsNum () - AsciiStrnIsHexNum () - AsciiStrnIsUpperHexNum () - AsciiStrnIsAlphaNum () Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace ToUpper() by CharToUpper(). Signed-off-by: Pierre Gondois <[email protected]>
pierregondois
force-pushed
the
pg/string_cleanup
branch
from
d06b1f6 to
6595952
Compare
Replace hard-coded string checks by the new utility functions added to BaseLib. Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace the macros defined in NetLib.h by the appropriate equivalent. Signed-off-by: Pierre Gondois <[email protected]>
Replace hard-coded string checks by the new utility functions added to BaseLib. Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace InternalAsciiIsDecimalDigitCharacter() by AsciiCharIsNum(). Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace InternalAsciiIsHexaDecimalDigitCharacter() by AsciiCharIsHexNum(). Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace IsAlnum() by AsciiCharIsAlphaNum(). Signed-off-by: Pierre Gondois <[email protected]>
pierregondois
force-pushed
the
pg/string_cleanup
branch
from
6595952 to
4fee099
Compare
os-d
approved these changes
Dec 4, 2025
Contributor
os-d
left a comment
os-d
left a comment
There was a problem hiding this comment.
Approved for EmulatorPkg and FatPkg.
With the newly added string function to BaseLib, replace IsValidDigitalChar() by: - AsciiStrnIsNum() - AsciiCharIsHexNum() Signed-off-by: Pierre Gondois <[email protected]>
Add the following string/char conversion functions: - AsciiCharToUpper () - AsciiCharToLower () - CharToLower () - StrnCharToUpper () - StrnCharToLower () CharToUpper() and AsciiCharToUpper() are just moved String.c. Signed-off-by: Pierre Gondois <[email protected]>
Replace hard-coded string checks by the new utility functions added to BaseLib. Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace UpperCaseString() by StrnCharToUpper(). Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace UpperCaseString() by StrnCharToUpper(). Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace LibToLowerString() by StrnCharToLower(). Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace VarCheckUefiIsHexaDecimalDigitCharacter() by StrCharIsUpperHexNum(). Signed-off-by: Pierre Gondois <[email protected]>
With the newly added string function to BaseLib, replace ToLower() by StrnCharToLower(). Signed-off-by: Pierre Gondois <[email protected]>
pierregondois
force-pushed
the
pg/string_cleanup
branch
from
4fee099 to
647950f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The edk2 repository contains multiple local implementations of string utilities:
Add string/char utilities to BaseLib and remove some of the local implementations.
Not all implementations have been replaced, but this is a first step.