Upload test results and reports as a composite action

Author: Jan Waś

.github/actions/upload/action.yml

@@ -0,0 +1,31 @@
+name: upload
+description: "Upload test results"
+inputs:
+  name-suffix:
+    default: ${{ github.job }}
+  test-report-retention-days:
+    default: 5
+
+runs:
+  using: composite
+  steps:
+    - name: Upload test results
+      uses: actions/upload-artifact@v3
+      # Upload all test reports only on failure, because the artifacts are large
+      if: failure()
+      with:
+        name: result ${{ inputs.name-suffix }}
+        path: |
+          **/target/surefire-reports
+          **/target/checkstyle-*
+    - name: Upload test report
+      uses: actions/upload-artifact@v3
+      # Always upload the test report for the annotate.yml workflow,
+      # but only the single XML file to keep the artifact small
+      if: always()
+      with:
+        # Name prefix is checked in the `Annotate checks` workflow
+        name: test report ${{ inputs.name-suffix }}
+        path: |
+          **/surefire-reports/TEST-*.xml
+        retention-days: ${{ inputs.test-report-retention-days }}

.github/workflows/ci.yml

@@ -173,26 +173,9 @@ jobs:
           if [ ! -f gib-impacted.log ] || grep -q testing/trino-test-jdbc-compatibility-old-server gib-impacted.log; then
             $MAVEN test ${MAVEN_TEST} -pl :trino-test-jdbc-compatibility-old-server
           fi
-      - name: Upload test results
-        uses: actions/upload-artifact@v3
-        # Upload all test reports only on failure, because the artifacts are large
-        if: failure()
+      - uses: ./.github/actions/upload
         with:
-          name: result ${{ github.job }}
-          path: |
-            **/target/surefire-reports
-            **/target/checkstyle-*
-      - name: Upload test report
-        uses: actions/upload-artifact@v3
-        # Always upload the test report for the annotate.yml workflow,
-        # but only the single XML file to keep the artifact small
-        if: always()
-        with:
-          # Name prefix is checked in the `Annotate checks` workflow
-          name: test report ${{ github.job }}
-          path: |
-            **/surefire-reports/TEST-*.xml
-          retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
+          test-report-retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
       - name: Clean local Maven repo
         # Avoid creating a cache entry because this job doesn't download all dependencies
         if: steps.cache.outputs.cache-hit != 'true'
@@ -295,26 +278,10 @@ jobs:
         run: |
           source plugin/trino-hive-hadoop2/conf/hive-tests-${{ matrix.config }}.sh &&
             plugin/trino-hive-hadoop2/bin/run_hive_alluxio_tests.sh
-      - name: Upload test results
-        uses: actions/upload-artifact@v3
-        # Upload all test reports only on failure, because the artifacts are large
-        if: failure()
+      - uses: ./.github/actions/upload
         with:
-          name: result ${{ github.job }}
-          path: |
-            **/target/surefire-reports
-            **/target/checkstyle-*
-      - name: Upload test report
-        uses: actions/upload-artifact@v3
-        # Always upload the test report for the annotate.yml workflow,
-        # but only the single XML file to keep the artifact small
-        if: always()
-        with:
-          # Name prefix is checked in the `Annotate checks` workflow
-          name: test report ${{ github.job }} (${{ matrix.config }})
-          path: |
-            **/surefire-reports/TEST-*.xml
-          retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
+          name-suffix: ${{ github.job }} (${{ matrix.config }})
+          test-report-retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
       - name: Clean local Maven repo
         # Avoid creating a cache entry because this job doesn't download all dependencies
         if: steps.cache.outputs.cache-hit != 'true'
@@ -364,26 +331,9 @@ jobs:
             !:trino-sqlserver,
             !:trino-test-jdbc-compatibility-old-server,
             !:trino-tests'
-      - name: Upload test results
-        uses: actions/upload-artifact@v3
-        # Upload all test reports only on failure, because the artifacts are large
-        if: failure()
+      - uses: ./.github/actions/upload
         with:
-          name: result ${{ github.job }}
-          path: |
-            **/target/surefire-reports
-            **/target/checkstyle-*
-      - name: Upload test report
-        uses: actions/upload-artifact@v3
-        # Always upload the test report for the annotate.yml workflow,
-        # but only the single XML file to keep the artifact small
-        if: always()
-        with:
-          # Name prefix is checked in the `Annotate checks` workflow
-          name: test report ${{ github.job }}
-          path: |
-            **/surefire-reports/TEST-*.xml
-          retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
+          test-report-retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
       - name: Clean local Maven repo
         # Avoid creating a cache entry because this job doesn't download all dependencies
         if: steps.cache.outputs.cache-hit != 'true'
@@ -551,26 +501,10 @@ jobs:
           # ", :, <, >, |, *, ?, \, / are not allowed in artifact names, replace it with an underscore
           name=$(echo -n "${{ matrix.modules }}" | sed -e 's/[":<>|\*\?\\\/]/_/g')
           echo "ARTIFACT_NAME=$name" >> $GITHUB_ENV
-      - name: Upload test results
-        uses: actions/upload-artifact@v3
-        # Upload all test reports only on failure, because the artifacts are large
-        if: failure()
+      - uses: ./.github/actions/upload
         with:
-          name: result ${{ env.ARTIFACT_NAME }}
-          path: |
-            **/target/surefire-reports
-            **/target/checkstyle-*
-      - name: Upload test report
-        uses: actions/upload-artifact@v3
-        # Always upload the test report for the annotate.yml workflow,
-        # but only the single XML file to keep the artifact small
-        if: always()
-        with:
-          # Name prefix is checked in the `Annotate checks` workflow
-          name: test report ${{ github.job }} (${{ env.ARTIFACT_NAME }})
-          path: |
-            **/surefire-reports/TEST-*.xml
-          retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
+          name-suffix: ${{ env.ARTIFACT_NAME }}
+          test-report-retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
       - name: Clean local Maven repo
         # Avoid creating a cache entry because this job doesn't download all dependencies
         if: steps.cache.outputs.cache-hit != 'true'