WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

fix(extension-code): modify input and paste regular expression #7124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zih0 wants to merge 4 commits into
base: develop
Choose a base branch
from
+7 −3
Open

fix(extension-code): modify input and paste regular expression #7124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
346dfb4
fix: extension-code regexp
Zih0 Oct 25, 2025
bf3006e
fix paste regex
Zih0 Oct 25, 2025
054988c
changeset
Zih0 Oct 25, 2025
5859c22
Merge branch 'develop' into fix/code-regexp
bdbch Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ninety-humans-raise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tiptap/extension-code': patch
---

Fixed inline code removing preceding character when typing
5 changes: 2 additions & 3 deletions packages/extension-code/src/code.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,11 @@ declare module '@tiptap/core' {
* This ensures that any text between backticks is formatted as code,
* regardless of the surrounding characters (exception being another backtick).
*/
export const inputRegex = /(^|[^`])`([^`]+)`(?!`)$/

export const inputRegex = /(?:^|\s)(`(?!\s+`)((?:[^`]+))`(?!\s+`))$/
/**
* Matches inline code while pasting.
*/
export const pasteRegex = /(^|[^`])`([^`]+)`(?!`)/g
export const pasteRegex = /(?:^|\s)(`(?!\s+`)((?:[^`]+))`(?!\s+`))/g
Comment on lines +40 to +44
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated regex patterns should have test coverage similar to the Bold extension. Consider adding a test file at packages/extension-code/__tests__/code.spec.ts to verify:

  1. The new regex correctly matches backtick-enclosed text when preceded by whitespace or at start of line
  2. The regex correctly rejects cases without proper whitespace (addressing the original bug where "a`b`" consumed the "a")
  3. Both inputRegex and pasteRegex match expected patterns

Example test structure (following Bold extension's pattern):

import { inputRegex, pasteRegex } from '@tiptap/extension-code'
import { describe, expect, it } from 'vitest'

describe('code regex test', () => {
  it('input regex matches code with space before', () => {
    expect(' `Test`').toMatch(inputRegex)
  })
  
  it('input regex matches code at start', () => {
    expect('`Test`').toMatch(inputRegex)
  })
  
  it('paste regex matches', () => {
    expect('`Test`').toMatch(pasteRegex)
  })
})

Copilot uses AI. Check for mistakes.

/**
* This extension allows you to mark text as inline code.
Expand Down
Loading