fix: Add a trailing newline to blockquote markdown rendering #7245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er separation from subsequent content.
🦋 Changeset detectedLatest commit: 1d3b9e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 70 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot finished reviewing on behalf of
bdbch
November 19, 2025 02:53
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where blockquotes rendered by the @tiptap/static-renderer markdown serializer were missing a trailing newline, causing them to merge incorrectly with subsequent content.
Key changes:
- Added a trailing
\nto the blockquote serialization logic - Added a regression test to verify proper separation between blockquotes and following paragraphs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/static-renderer/src/pm/markdown/markdown.ts | Fixed blockquote serializer to append a trailing newline, ensuring proper markdown formatting |
| tests/cypress/integration/static-renderer/md-string.spec.ts | Added test case verifying blockquote-paragraph separation with the expected output format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@tiptap/extension-dropcursor
@tiptap/extension-character-count
@tiptap/extension-gapcursor
@tiptap/extension-focus
@tiptap/extension-list-item
@tiptap/extension-history
@tiptap/extension-list-keymap
@tiptap/extension-placeholder
@tiptap/extension-table-cell
@tiptap/extension-table-header
@tiptap/extension-table-row
@tiptap/extension-task-item
@tiptap/core
@tiptap/extension-task-list
@tiptap/extension-blockquote
@tiptap/extension-bold
@tiptap/extension-bullet-list
@tiptap/extension-code
@tiptap/extension-bubble-menu
@tiptap/extension-code-block-lowlight
@tiptap/extension-code-block
@tiptap/extension-collaboration
@tiptap/extension-collaboration-caret
@tiptap/extension-color
@tiptap/extension-details
@tiptap/extension-document
@tiptap/extension-drag-handle
@tiptap/extension-drag-handle-vue-2
@tiptap/extension-drag-handle-react
@tiptap/extension-drag-handle-vue-3
@tiptap/extension-floating-menu
@tiptap/extension-emoji
@tiptap/extension-file-handler
@tiptap/extension-font-family
@tiptap/extension-hard-break
@tiptap/extension-heading
@tiptap/extension-highlight
@tiptap/extension-horizontal-rule
@tiptap/extension-image
@tiptap/extension-invisible-characters
@tiptap/extension-italic
@tiptap/extension-link
@tiptap/extension-list
@tiptap/extension-mathematics
@tiptap/extension-node-range
@tiptap/extension-ordered-list
@tiptap/extension-mention
@tiptap/extension-paragraph
@tiptap/extension-strike
@tiptap/extension-subscript
@tiptap/extension-table
@tiptap/extension-superscript
@tiptap/extension-table-of-contents
@tiptap/extension-text-align
@tiptap/extension-text
@tiptap/extension-text-style
@tiptap/extension-typography
@tiptap/extension-underline
@tiptap/extension-unique-id
@tiptap/extension-youtube
@tiptap/extensions
@tiptap/html
@tiptap/markdown
@tiptap/pm
@tiptap/react
@tiptap/starter-kit
@tiptap/static-renderer
@tiptap/vue-2
@tiptap/suggestion
@tiptap/vue-3
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Fixed an issue where blockquotes rendered by the
@tiptap/static-renderermarkdown serializer were missing a trailing newline. This caused blockquotes to merge with subsequent content (e.g., paragraphs) instead of being properly separated.Implementation Approach
Updated the
blockquoteserialization logic in packages/static-renderer/src/pm/markdown/markdown.ts to append a newline (\n) to the end of the rendered blockquote string.Testing Done
pnpx cypress run.Verification Steps
Run the static renderer markdown tests:
Additional Notes
The issue was specific to the static-renderer package and did not affect the main markdown extension.
Checklist
Related Issues
Fixes #7223