Confirm execv P/Invoke implementation is correct #491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed feedback on #490 regarding the
execvP/Invoke signature. After review, the current implementation is correct:["/bin/sh", tempScript, null!]properly followsexecvsemantics—first element is program name, followed by arguments, null-terminatedstring[]to the nativechar* argv[]including the null terminatorNo code changes required—the bot reviewer's concerns were unfounded.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.