Install software after workers

[radekg]

This PR addresses #676. Install the software after workers so that when Cilium is installed, there are workers to deploy the CNI pods to.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[vitobotta]

Hi @radekg , sorry for the delay. I cannot merge the pull request as is because it breaks the creation of the cluster for default and more common configurations. By moving the installation of the software to after the installation of k3s on the workers, the create command gets stuck after setting up the workers because they cannot reach a ready state without the CCM being installed first. And then the Cluster Autoscaler installation has to wait for at least one worker to be ready. So the process hangs. Can you please try to figure out a way to make it work with your Cilium config without affecting more common use cases? As another user pointed out in the original thread, they don't have problems with Cilium on several clusters, so it has to be an issue with your particular configuration that requires some changes.

[vitobotta]

See other comment :)

[radekg]

I'm not sure what breaks the nodes in this case because the exact fixed the problem for Cilium installation.
Having said that, I am not in a position to be burn cycles on figuring out the edge cases I do not use. Feel free to close the issue. I can live with my patched version.

[vitobotta]

Let's leave it open for now so I can see if I can find the time to reproduce the issue and look into finding a fix that doesnt break more common configurations.

[radekg]

Thank you. I understand your concerns regarding other use cases getting broken for whatever reason. The issue with the CNI is that it has to go in first before anything else, and before the first worker can join when workloads land on workers instead of master nodes.