fix: use spawn_callback to avoid blocking socket ping/pongs #1541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
trungleduc
reviewed
Nov 6, 2025
| executor.kc = await executor.async_start_new_kernel_client() | ||
|
|
||
| # schedule notebook run and return so we don't block other messages | ||
| IOLoop.current().spawn_callback(self._run_notebook, nb, executor) |
Member
There was a problem hiding this comment.
Can we call add_callback directly? https://github.com/tornadoweb/tornado/blob/d30ef74020924be5f214091de95314ca3ce919af/tornado/ioloop.py#L673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
When using progressive rendering to render reports that take more than 90s, the report hangs indefinitely.
Reproduced with a cell
Code changes
I tracked this down to tornadoweb/tornado#2021. In our case, the execution handler's on_message method blocks any ping/pong requests from being received, resulting in the websocket being closed after 90s
I've taken their recommend approach and offloaded the notebook handling to spawn_callback.
User-facing changes
Slow reports that previously hung will now render.
Backwards-incompatible changes