chore: cleanup and update tests

Author: rzzf

lib/rules/no-undef-directives.js

@@ -36,24 +36,12 @@ function getRegisteredDirectives(componentObject) {
   }
 
   return directivesNode.value.properties
-    .filter(
-      /**
-       * @param {Property | SpreadElement} node
-       * @returns {node is Property}
-       */
-      (node) => node.type === 'Property'
-    )
+    .filter((node) => node.type === 'Property')
     .map((node) => {
       const name = utils.getStaticPropertyName(node)
       return name ? { node, name } : null
     })
-    .filter(
-      /**
-       * @param {{node: Property, name: string} | null} res
-       * @returns {res is {node: Property, name: string}}
-       */
-      (res) => res !== null
-    )
+    .filter((res) => !!res)
 }
 
 class DefinedInSetupDirectives {
@@ -80,10 +68,7 @@ class DefinedInSetupDirectives {
   isDefinedDirective(rawName) {
     const camelName = camelize(rawName)
     const variableName = `v${casing.capitalize(camelName)}`
-    if (this.names.has(variableName)) {
-      return true
-    }
-    return false
+    return this.names.has(variableName)
   }
 }
 
@@ -222,13 +207,11 @@ module.exports = {
       })
 
       verifyName = (rawName, reportNode) => {
-        if (!isVerifyTargetDirective(rawName)) {
-          return
-        }
-        if (definedInSetupDirectives.isDefinedDirective(rawName)) {
-          return
-        }
-        if (definedInOptionDirectives.isDefinedDirective(rawName)) {
+        if (
+          !isVerifyTargetDirective(rawName) ||
+          definedInSetupDirectives.isDefinedDirective(rawName) ||
+          definedInOptionDirectives.isDefinedDirective(rawName)
+        ) {
           return
         }
 
@@ -251,10 +234,10 @@ module.exports = {
       })
 
       verifyName = (rawName, reportNode) => {
-        if (!isVerifyTargetDirective(rawName)) {
-          return
-        }
-        if (definedInOptionDirectives.isDefinedDirective(rawName)) {
+        if (
+          !isVerifyTargetDirective(rawName) ||
+          definedInOptionDirectives.isDefinedDirective(rawName)
+        ) {
           return
         }
 

tests/lib/rules/no-undef-directives.js

@@ -241,7 +241,10 @@ tester.run('no-undef-directives', rule, {
       errors: [
         {
           message: "The 'v-focus' directive has been used, but not defined.",
-          line: 3
+          line: 3,
+          column: 14,
+          endLine: 3,
+          endColumn: 21
         }
       ]
     },
@@ -258,7 +261,10 @@ tester.run('no-undef-directives', rule, {
       errors: [
         {
           message: "The 'v-focus' directive has been used, but not defined.",
-          line: 6
+          line: 6,
+          column: 14,
+          endLine: 6,
+          endColumn: 21
         }
       ]
     },
@@ -275,7 +281,10 @@ tester.run('no-undef-directives', rule, {
       errors: [
         {
           message: "The 'v-foo' directive has been used, but not defined.",
-          line: 6
+          line: 6,
+          column: 14,
+          endLine: 6,
+          endColumn: 19
         }
       ]
     },
@@ -292,7 +301,10 @@ tester.run('no-undef-directives', rule, {
       errors: [
         {
           message: "The 'v-focus' directive has been used, but not defined.",
-          line: 6
+          line: 6,
+          column: 14,
+          endLine: 6,
+          endColumn: 21
         }
       ]
     },
@@ -310,7 +322,10 @@ tester.run('no-undef-directives', rule, {
         {
           message:
             "The 'v-clickoutside' directive has been used, but not defined.",
-          line: 6
+          line: 6,
+          column: 14,
+          endLine: 6,
+          endColumn: 28
         }
       ]
     },
@@ -328,7 +343,10 @@ tester.run('no-undef-directives', rule, {
         {
           message:
             "The 'v-click-outside' directive has been used, but not defined.",
-          line: 6
+          line: 6,
+          column: 14,
+          endLine: 6,
+          endColumn: 29
         }
       ]
     },
@@ -342,7 +360,10 @@ tester.run('no-undef-directives', rule, {
       errors: [
         {
           message: "The 'v-foo' directive has been used, but not defined.",
-          line: 3
+          line: 3,
+          column: 14,
+          endLine: 3,
+          endColumn: 25
         }
       ]
     },
@@ -356,7 +377,10 @@ tester.run('no-undef-directives', rule, {
       errors: [
         {
           message: "The 'v-foo' directive has been used, but not defined.",
-          line: 3
+          line: 3,
+          column: 14,
+          endLine: 3,
+          endColumn: 23
         }
       ]
     },
@@ -370,7 +394,10 @@ tester.run('no-undef-directives', rule, {
       errors: [
         {
           message: "The 'v-foo' directive has been used, but not defined.",
-          line: 3
+          line: 3,
+          column: 14,
+          endLine: 3,
+          endColumn: 27
         }
       ]
     },
@@ -391,7 +418,10 @@ tester.run('no-undef-directives', rule, {
       errors: [
         {
           message: "The 'v-Focus' directive has been used, but not defined.",
-          line: 10
+          line: 10,
+          column: 14,
+          endLine: 10,
+          endColumn: 21
         }
       ]
     },
@@ -412,7 +442,10 @@ tester.run('no-undef-directives', rule, {
       errors: [
         {
           message: "The 'v-foo-bar' directive has been used, but not defined.",
-          line: 10
+          line: 10,
+          column: 14,
+          endLine: 10,
+          endColumn: 23
         }
       ]
     },
@@ -427,7 +460,10 @@ tester.run('no-undef-directives', rule, {
       errors: [
         {
           message: "The 'v-foo-bar' directive has been used, but not defined.",
-          line: 3
+          line: 3,
+          column: 14,
+          endLine: 3,
+          endColumn: 23
         }
       ]
     }