refactor: apply suggest

Author: rzzf

docs/rules/no-undef-directives.md

@@ -69,7 +69,7 @@ export default {
 }
 ```
 
-- `"ignore"` (`string[]`) An array of tags or regular expression patterns (e.g. `"/^custom-/"`) that ignore these rules. This option will check both kebab-case and PascalCase versions of the given tag names. Default is empty.
+- `"ignore"` (`string[]`) An array of directive names or regular expression patterns (e.g. `"/^custom-/"`) that ignore these rules. This option will check both kebab-case and PascalCase versions of the given directive names. Default is empty.
 
 ### `"ignore": ["foo"]`
 

lib/rules/no-undef-directives.js

@@ -8,14 +8,6 @@ const utils = require('../utils')
 const casing = require('../utils/casing')
 const regexp = require('../utils/regexp')
 
-/**
- * @param {string} str
- * @returns {string}
- */
-function camelize(str) {
-  return str.replace(/-(\w)/g, (_, c) => (c ? c.toUpperCase() : ''))
-}
-
 /**
  * @param {ObjectExpression} componentObject
  * @returns { { node: Property, name: string }[] } Array of ASTNodes
@@ -36,21 +28,20 @@ function getRegisteredDirectives(componentObject) {
     return []
   }
 
-  return directivesNode.value.properties
-    .filter((node) => node.type === 'Property')
-    .map((node) => {
-      const name = utils.getStaticPropertyName(node)
-      return name ? { node, name } : null
-    })
-    .filter((res) => !!res)
+  // @ts-ignore
+  return directivesNode.value.properties.flatMap((node) => {
+    const name =
+      node.type === 'Property' ? utils.getStaticPropertyName(node) : null
+    return name ? [{ node, name }] : []
+  })
 }
 
 /**
  * @param {string} rawName
  * @param {Set<string>} definedNames
  */
 function isDefinedInSetup(rawName, definedNames) {
-  const camelName = camelize(rawName)
+  const camelName = casing.camelCase(rawName)
   const variableName = `v${casing.capitalize(camelName)}`
   return definedNames.has(variableName)
 }
@@ -60,8 +51,9 @@ function isDefinedInSetup(rawName, definedNames) {
  * @param {Set<string>} definedNames
  */
 function isDefinedInOptions(rawName, definedNames) {
-  const camelName = camelize(rawName)
-  if (definedNames.has(rawName) || definedNames.has(camelName)) {
+  const camelName = casing.camelCase(rawName)
+
+  if (definedNames.has(rawName)) {
     return true
   }
 
@@ -153,12 +145,13 @@ module.exports = {
       }
     }
 
+    /** @type {Set<string>} */
+    const definedInOptionDirectives = new Set()
+
     if (utils.isScriptSetup(context)) {
       // For <script setup>
       /** @type {Set<string>} */
       const definedInSetupDirectives = new Set()
-      /** @type {Set<string>} */
-      const definedInOptionDirectives = new Set()
 
       const globalScope = context.sourceCode.scopeManager.globalScope
       if (globalScope) {
@@ -168,7 +161,7 @@ module.exports = {
         const moduleScope = globalScope.childScopes.find(
           (scope) => scope.type === 'module'
         )
-        for (const variable of (moduleScope && moduleScope.variables) || []) {
+        for (const variable of moduleScope?.variables ?? []) {
           definedInSetupDirectives.add(variable.name)
         }
       }
@@ -192,26 +185,23 @@ module.exports = {
         templateBodyVisitor,
         scriptVisitor
       )
-    } else {
-      // For Options API
-      /** @type {Set<string>} */
-      const definedInOptionDirectives = new Set()
+    }
 
-      const scriptVisitor = utils.executeOnVue(context, (obj) => {
-        for (const directive of getRegisteredDirectives(obj)) {
-          definedInOptionDirectives.add(directive.name)
-        }
-      })
+    // For Options API
+    const scriptVisitor = utils.executeOnVue(context, (obj) => {
+      for (const directive of getRegisteredDirectives(obj)) {
+        definedInOptionDirectives.add(directive.name)
+      }
+    })
 
-      const templateBodyVisitor = createTemplateBodyVisitor((rawName) =>
-        isDefinedInOptions(rawName, definedInOptionDirectives)
-      )
+    const templateBodyVisitor = createTemplateBodyVisitor((rawName) =>
+      isDefinedInOptions(rawName, definedInOptionDirectives)
+    )
 
-      return utils.defineTemplateBodyVisitor(
-        context,
-        templateBodyVisitor,
-        scriptVisitor
-      )
-    }
+    return utils.defineTemplateBodyVisitor(
+      context,
+      templateBodyVisitor,
+      scriptVisitor
+    )
   }
 }