The consistently failing spec

This has been mentioned in the other PR, and I remember a couple of random build failures in the past. Can someone point me to a failed build or provide intel? Let's try to come up with a fix. ⚡

[samwgoldman]

Pretty sure this is a cascading failure in the adapter specs. Seems the most common culprit is the Reel adapter spec. If it fails, the next adapter test fails too. I struggled with the flakiness of these tests for a long time. They pass consistently on my machine every time, but not so much on Travis.

[tarcieri]

Can you point me at one of the Reel failures?

[samwgoldman]

Here's a JRuby test run where the Reel adapter fails. Later, the Rack adapter fails.

https://travis-ci.org/seancribbs/webmachine-ruby/jobs/12748305

I'm able to unreliably reproduce this with bundle exec rspec --order rand:53167 spec/webmachine/.

That's the spec seed of https://travis-ci.org/seancribbs/webmachine-ruby/jobs/12748303

I'm not sure we should bother fixing the root cause of this leak. We could as well just use a fresh random port for each example, and let garbage collection take care of the rest. And when the process exits, they'll get released anyway.

Example: https://github.com/lgierth/aeee/blob/master/spec/support/helper.rb#L15-L20

[samwgoldman]

Yeah, I previously had the adapter tests do just that (89ce86e). I removed that because I thought I had gotten the servers to play nice and shut down.

Seems like web servers generally expect to be at the center of the universe. Maybe the Adapter#shutdown API is just a pipe dream.

[nyarly]

(PR reference was a typo)

One of today's builds shows a new error from Reel on rbx-19mode: https://travis-ci.org/seancribbs/webmachine-ruby/jobs/14224187#L1622

Could it be this is the actual error? Maybe the error gets swallowed most of the time due to something. It also always seem to be the same three examples that fail, except for the mentioned JRuby failure - where it's all of the examples in that example group.

On the other hand, the error could as well just be a different symptom of something network-related.

cc @tarcieri

[tarcieri]

@lgierth hmmm...

ArgumentError: Data object has already been freed

This could either be an http_parser.rb bug on a Reel bug. Not sure? /cc @tmm1

I just experienced another symptom, the first example hangs indefinitely, and isn't even affected by timeout(5) in #reel_server: https://gist.github.com/lgierth/7554999

Note how i send SIGINT in line 6, and the difference in time between the former and latter log timestamps.

Also note the spec command which uses --order rand:53167, as an earlier CI failure did (see my first comment after opening this issue), but runs only the Reel spec.

the first example hangs indefinitely

And obviously also the second example, as I sent SIGINT again in line 7...