chore: fix PointerType Hash/Eq consistency #2439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwalker
requested changes
Dec 9, 2025
Collaborator
bitwalker
left a comment
bitwalker
left a comment
There was a problem hiding this comment.
The test coverage here is unnecessary IMO, or at least, doesn't feel like the value of them balances out the amount of noise they introduce. If we actually wanted to validate that we aren't making mistakes like this with Rust's various traits, we'd need an enormous number of such tests, and that's just not a valuable use of time as far as I'm concerned.
Otherwise, looks good - if you can remove the test code from this PR, leaving just the patch of the Hash impl, I'll merge.
KitaroMoha563
force-pushed
the
fix-pointer-hash
branch
from
cc8e147 to
24fca39
Compare
Contributor
Author
|
Hi @bitwalke, removed the test code, pls check ,thanks! |
bitwalker
approved these changes
Dec 10, 2025
plafer
added
the
no changelog
Contributor
|
Hey @KitaroMoha563 can you sign your commits? Then we can merge. |
KitaroMoha563
force-pushed
the
fix-pointer-hash
branch
2 times, most recently
from
8d00eb1 to
d216663
Compare
Contributor
Author
|
@plafer did it, sir. |
Signed-off-by: Kitaro Mohan <[email protected]>
KitaroMoha563
force-pushed
the
fix-pointer-hash
branch
from
d216663 to
fc0c82d
Compare
plafer
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PointerType hashed addrspace directly but compared via address_space(), causing equal values to have different hashes.