WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@claytoncollie
Copy link
Contributor

Description of the Change

Small refactor to move functionality out of the theme and into the mu-plugin. Also, after some testing, the original code was not be instantiated in the theme at all. This change not only moves it but also gets it working properly again.

Closes #249

How to test the Change

  1. Check out trunk
  2. View the source on the frontend
  3. Search for wp-emoji-styles-inline-css
  4. Verify it does exist
  5. Checkout this branch
  6. Refresh the source
  7. Verify that wp-emoji-styles-inline-css does NOT exist

Changelog Entry

Changed - moved emoji overrides from theme to plugin

Credits

Props @claytoncollie

Checklist:

Copy link
Contributor

@tobeycodes tobeycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Aside from this I think we should review these actions and see if they are still relevant in 2025.

@darylldoyle darylldoyle merged commit 44721b1 into trunk Jan 6, 2025
7 checks passed
@darylldoyle darylldoyle deleted the feature/overrides-location branch January 6, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move non theme related code to the plugin

3 participants