Update to Alchemy 8.0 #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are breaking and it is not worth supporting both in the same Gem version
We need an asset pipeline for the dummy app. Signed-off-by: Thomas von Deyen <[email protected]>
It has changed from positional key and value arguments to a config hash. Signed-off-by: Thomas von Deyen <[email protected]>
Alchemy 8.0 disables caching for restricted pages and now returns a max-age of 0. Signed-off-by: Thomas von Deyen <[email protected]>
Do not prepend image to file mime type. Alchemy 8 now returns the proper mime type. Also the picture factory does not allow anymore to pass the file size. Let’s use the size from the actual image used in the factory. Signed-off-by: Thomas von Deyen <[email protected]>
The factories now need to create the attachment. Stubbing does not work anymore with Alchemy 8 and its attachment adapters. Signed-off-by: Thomas von Deyen <[email protected]>
tvdeyen
added
breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are breaking and it is not worth supporting both
in the same Gem version