WARNING: THIS SITE IS A MIRROR OF GITHUB.COM / IT CANNOT LOGIN OR REGISTER ACCOUNTS / THE CONTENTS ARE PROVIDED AS-IS / THIS SITE ASSUMES NO RESPONSIBILITY FOR ANY DISPLAYED CONTENT OR LINKS / IF YOU FOUND SOMETHING MAY NOT GOOD FOR EVERYONE, CONTACT ADMIN AT ilovescratch@foxmail.com
Skip to content

Conversation

@jviau
Copy link
Contributor

@jviau jviau commented Dec 11, 2025

Issue describing the changes in this PR

Part of #3141

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Includes the existing analyzers as implicit package references. We will work on directly embedding the analyzers in the SDK later.

Copilot AI review requested due to automatic review settings December 11, 2025 19:46
@jviau jviau changed the title Implicitly reference existing SDK analyzer packages [MSBUILD SDK] Implicitly reference existing SDK analyzer packages Dec 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds implicit package references for the SDK analyzer and generator packages to the Azure Functions SDK, enabling automatic inclusion of code analyzers and source generators in Azure Functions projects without requiring explicit package references from users.

  • Adds two new implicit package references (Analyzers v1.2.2 and Generators v1.3.6) to Azure.Functions.Sdk.props
  • Updates integration tests to verify the new implicit package references are properly included

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Azure.Functions.Sdk/Targets/Azure.Functions.Sdk.props Adds PackageReference elements for Microsoft.Azure.Functions.Worker.Sdk.Analyzers (v1.2.2) and Microsoft.Azure.Functions.Worker.Sdk.Generators (v1.3.6) with IsImplicitlyDefined="true"
test/Azure.Functions.Sdk.Tests/Integration/SdkEndToEndTests.Items.cs Updates Item_WorkerPackage_IsIncluded test to verify all three implicit package references (Worker, Analyzers, and Generators) and removes version-specific assertion for Worker package

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants