APF 420 #86
APF 420 #86
Conversation
| /** | ||
| * @return string | ||
| */ | ||
| protected function renderUpdateNotification(): string |
There was a problem hiding this comment.
An improvement could be here made by separating the HTML rendering to a separate block class/view model with .phtml template.
$updateNotificationBlock = $this->layout->createBlock(<block_path>); return $updateNotificationBlock->toHtml();
where the template path is set in the constructor or as an overridden property in the block class.
| return $html; | ||
| } | ||
|
|
||
| protected function _getHeaderTitleHtml($element): string |
There was a problem hiding this comment.
Also could be a separate block for rendering the html
| /** | ||
| * module JSON url | ||
| */ | ||
| const URL = 'https://repo.packagist.org/p2/amzn/amazon-pay-magento-2-module.json'; |
There was a problem hiding this comment.
Maybe not an improvement, but a neat alternative. You can move this hard coded value to xml configuration.
private string $repoSource; public function __construct(string $repoSource = '') { $this->repoSource = $repoSource; }
di.xml
<type name="<class>"> <arguments> <argument name="repoSource" xsi:type="string">https://repo.packagist.org/p2/amzn/amazon-pay-magento-2-module.json</argument> </arguments> </type>
Added "New version update available" message notice on Amazon Payment settings.